feat!: don't "fix" licenses if not needed #995#996
Draft
Rohankaf wants to merge 3 commits intoCycloneDX:mainfrom
Draft
feat!: don't "fix" licenses if not needed #995#996Rohankaf wants to merge 3 commits intoCycloneDX:mainfrom
Rohankaf wants to merge 3 commits intoCycloneDX:mainfrom
Conversation
Member
|
this current "patch" does not solve anything relkated to #995 |
Member
|
Hello @Rohankaf , I noticed you are quite new to contributing to open source. I converted your pull request to "draft", since it is not ready in its current state.
please address the previously mentioned things. |
Member
|
i see you opened another PR: #997 there is no need to create a new branch and open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
licenses_fixupfunction would always "fix" licenses even if they were already compliant.With CycloneDX 1.7, this is no longer needed.
This change: