Conversation
… url map to reflect PyPI heuristics Signed-off-by: Eesh Sahay <eesh.sahay@ufl.edu>
eeshs
force-pushed
the
feature/url-map-heuristics
branch
from
c50992f to
284c023
Compare
|
where do these additions come from? are there any docs for this? |
| 'donation': ExternalReferenceType.SOCIAL, | ||
| 'donate': ExternalReferenceType.SOCIAL | ||
| } | ||
| URL_MAP = { |
There was a problem hiding this comment.
unused symbol?
what is it for?
This is in reference to issue #800 "extend project URLs -> external references", I made the additions according to the specified domains in this document that was provided under the issue here: https://docs.pypi.org/project_metadata/#icons. It was my understanding that the code needed to be updated to be able to match the specified URL labels and URLs found in the doc to their proper external reference types. Please let me know if I am misunderstanding what needs to be done. |
|
could you add tests for that new implementation? |
| 'repository': ExternalReferenceType.VCS, | ||
| 'github': ExternalReferenceType.VCS, | ||
| 'chat': ExternalReferenceType.CHAT, | ||
| 'sponsor': ExternalReferenceType.SOCIAL, |
There was a problem hiding this comment.
"sponsor","donation", "donate" - this is an undesired category mapping to "social".
thats not what social is for. see https://cyclonedx.org/docs/1.6/json/#externalReferences_items_type
| 'changelog': ExternalReferenceType.RELEASE_NOTES, | ||
| 'changes': ExternalReferenceType.RELEASE_NOTES, | ||
| 'releasenotes': ExternalReferenceType.RELEASE_NOTES, | ||
| 'news': ExternalReferenceType.RELEASE_NOTES, |
There was a problem hiding this comment.
"news","whatsnew" can be anything, not only release notes - i think this is undesired
2 participants
Extended existing label map coverage and added URL map to match PyPI heuristics.