Fix error if API returns return code 1 as int#12
Merged
artemlos merged 1 commit intoCryptolens:masterfrom Oct 4, 2019
tgamauf:error-blocked-trial-key
Merged
Fix error if API returns return code 1 as int#12artemlos merged 1 commit intoCryptolens:masterfrom tgamauf:error-blocked-trial-key
artemlos merged 1 commit intoCryptolens:masterfrom
tgamauf:error-blocked-trial-key
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REST-API returns the return code 1 as a string in most situations, but as an integer in others. The Python-API cannot handle it if an integer is returned.
Steps to reproduce:
This is a fix for this behavior.
A note on the side - I would consider this inconsistent behavior of the API a bug, which should be fixed in the REST-API ultimatively.