Skip to content

Fixed minimum OID length (allow 2 arcs instead of 3) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crypt32 merged 1 commit into from
Aug 1, 2024
Merged

Fixed minimum OID length (allow 2 arcs instead of 3) #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Asn1Parser/Universal/Asn1ObjectIdentifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ static String decode(Asn1Reader asn) {
}
static Boolean validateOidString(String oid, out List<BigInteger> tokens) {
String[] strTokens = oid.Split('.');
if (strTokens.Length < 3) {
tokens = null;
if (strTokens.Length < 2) {
tokens = [];
return false;
}
tokens = new List<BigInteger>();
tokens = [];
for (Int32 index = 0; index < strTokens.Length; index++) {
try {
var value = BigInteger.Parse(strTokens[index]);
Expand All @@ -148,7 +148,7 @@ static Boolean validateOidString(String oid, out List<BigInteger> tokens) {
}
tokens.Add(value);
} catch {
tokens = null;
tokens = [];
return false;
}
}
Expand Down
39 changes: 39 additions & 0 deletions tests/Asn1Parser.Tests/Asn1OidTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
using System;
using System.IO;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using SysadminsLV.Asn1Parser.Universal;

namespace Asn1Parser.Tests;

[TestClass]
public class Asn1OidTests {
[TestMethod, Description("Test if at least two arcs are encoded.")]
public void TestMinStringLengthEncode() {
var oid = new Asn1ObjectIdentifier("0.0");
Assert.AreEqual("0.0", oid.Value.Value);
String encodedB64 = Convert.ToBase64String(oid.GetRawData());
Assert.AreEqual("BgEA", encodedB64);
}
[TestMethod, Description("Test if at least two arcs are required.")]
public void TestMinStringLengthDecode() {
Byte[] rawData = Convert.FromBase64String("BgEA");
var oid = new Asn1ObjectIdentifier(rawData);
Assert.AreEqual("0.0", oid.Value.Value);
String encodedB64 = Convert.ToBase64String(oid.GetRawData());
Assert.AreEqual("BgEA", encodedB64);
}
[TestMethod, Description("Test if single arc encoding fails.")]
[ExpectedException(typeof(InvalidDataException))]
public void TestSingleArcEncodeFail() {
new Asn1ObjectIdentifier("0");
}
[TestMethod, Description("Test if 2nd arc under 'ITU' root node encoded up to 39.")]
public void TestItuRootArcConstraintsPass() {
new Asn1ObjectIdentifier("1.39");
}
[TestMethod, Description("Test if 2nd arc under 'ITU' root node >39 fails.")]
[ExpectedException(typeof(InvalidDataException))]
public void TestItuRootArcConstraintsFail() {
new Asn1ObjectIdentifier("1.40");
}
}