Repository navigation
Fix RTL action drag handle overlap - #734
Open
ali-niyazi wants to merge 1 commit into
Open
ali-niyazi wants to merge 1 commit into
ali-niyazi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Post Submit Actions drag handle being blocked by the action controls overlay in RTL layouts.
Problem
In RTL mode,
FlexActionButtonssetsleft: 0while retaining the baseright: 0declaration.Because the element is absolutely positioned with
width: auto, having both horizontal offsets set causes the overlay to span the action row and intercept pointer interaction over the drag handle.As a result, the action drag handle becomes difficult or impossible to use in RTL.
Fix
Reset the inherited right offset in the RTL rule:
This keeps the controls anchored to the left in RTL without extending their hit area across the drag handle.
Testing
actions-v2production build completes successfully.right: autorule.Fixes #721