Skip to content

[BUG] fix race condition in heartbeat unittest#534

Merged
mga-chka merged 1 commit into
ContentSquare:masterfrom
odemkovych:fix-heartbeat-unittest
Apr 15, 2025
Merged

[BUG] fix race condition in heartbeat unittest#534
mga-chka merged 1 commit into
ContentSquare:masterfrom
odemkovych:fix-heartbeat-unittest

Conversation

@odemkovych
Copy link
Copy Markdown
Contributor

@odemkovych odemkovych commented Apr 4, 2025

Description

Fixing unittest race condition by adding locks. #533

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

@odemkovych
Copy link
Copy Markdown
Contributor Author

odemkovych commented Apr 4, 2025

@mga-chka please approve CI

@mga-chka mga-chka merged commit 44562eb into ContentSquare:master Apr 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mga-chka mga-chka mga-chka approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@odemkovych @mga-chka