ConnectionMaster · pull · Jan 25, 2021 · Jan 25, 2021 · Jan 25, 2021 · Jan 25, 2021
diff --git a/.readme/demo.gif b/.readme/demo.gif
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.23.1
+
+### Fixes
+
+- Update the new "Create Pull Request" icon to be a sharper image.
+
 ## 0.23.0
 
 ### Changes

diff --git a/README.md b/README.md
@@ -3,7 +3,7 @@
 > Review and manage your GitHub pull requests and issues directly in VS Code
 
 This extension allows you to review and manage GitHub pull requests and issues in Visual Studio Code. The support includes:
-- Authenticating and connecting VS Code to GitHub.
+- Authenticating and connecting VS Code to GitHub. **Note**: GitHub Enterprise is not supported
 - Listing and browsing PRs from within VS Code.
 - Reviewing PRs from within VS Code with in-editor commenting.
 - Validating PRs from within VS Code with easy checkouts.
@@ -21,13 +21,11 @@ This extension allows you to review and manage GitHub pull requests and issues i
 # Getting Started
 It's easy to get started with GitHub Pull Requests for Visual Studio Code. Simply follow these steps to get started.
 
-1. Make sure you have VSCode version 1.27.0 or higher.
-1. Download the extension from [the marketplace](https://aka.ms/vscodepr-download).
-1. Reload VS Code after the installation (click the reload button next to the extension).
-1. Open your desired GitHub repository.
-1. If you're using version 0.5.0 of the extension or higher, a new viewlet should be added to the bottom of the activity bar. For older versions, the `GitHub Pull Requests` treeview will appear in the SCM Viewlet.
+1. Install the extension from within VS Code or download it from [the marketplace](https://aka.ms/vscodepr-download).
+1. Open your desired GitHub repository in VS Code.
+1. A new viewlet will appear on the activity bar which shows a list of pull requests and issues.
+1. Use the button on the viewlet to sign in to GitHub.
 1. You may need to configure the `githubPullRequests.remotes` setting, by default the extension will look for PRs for `origin` and `upstream`. If you have different remotes, add them to the remotes list.
-1. A notification should appear asking you to sign in to GitHub; follow the directions to authenticate.
 1. You should be good to go!
 
 # Configuring the extension

diff --git a/documentation/IssueFeatures.md b/documentation/IssueFeatures.md
@@ -11,7 +11,7 @@ You can also create an issue from a text selection by running the **Create Issue
 
 # Commands
 
-There are two new commands for easily creating GitHub permalinks. The **Copy GitHub Permalink** command will take the text you have selected and make a git hub permalink. The **Open Permalink in GitHub** command creates the same permalink, but also opens the link in your browser.
+There are two new commands for easily creating GitHub permalinks. The **Copy GitHub Permalink** command will take the text you have selected and make a git hub permalink. The **Open Permalink on GitHub** command creates the same permalink, but also opens the link in your browser.
 
 # Inline Completion Suggestions
 

diff --git a/package.json b/package.json
@@ -12,10 +12,10 @@
   },
   "enableProposedApi": true,
   "preview": true,
-  "version": "0.22.0",
+  "version": "0.23.1",
   "publisher": "GitHub",
   "engines": {
-    "vscode": "^1.53.0"
+    "vscode": "^1.53.2"
   },
   "categories": [
     "Other"
@@ -59,6 +59,7 @@
           }
         },
         "githubPullRequests.pullRequestTitle": {
+          "deprecationMessage": "The pull request title now uses the same defaults as GitHub, and can be edited before create.",
           "type": "string",
           "enum": [
             "commit",
@@ -76,6 +77,7 @@
           "description": "The title used when creating pull requests."
         },
         "githubPullRequests.pullRequestDescription": {
+          "deprecationMessage": "The pull request description now uses the same defaults as GitHub, and can be edited before create.",
           "type": "string",
           "enum": [
             "template",
@@ -362,7 +364,12 @@
         {
           "id": "github-pull-requests",
           "title": "GitHub",
-          "icon": "resources/icons/pull-request.png"
+          "icon": "$(github)"
+        },
+        {
+          "id": "github-pull-request",
+          "title": "GitHub Pull Request",
+          "icon": "$(git-pull-request)"
         }
       ]
     },
@@ -374,31 +381,20 @@
           "when": "ReposManagerStateContext == NeedsAuthentication",
           "icon": "resources/icons/pull-request.png"
         },
-        {
-          "id": "prStatus:github",
-          "name": "Changes In Pull Request",
-          "when": "github:inReviewMode",
-          "icon": "resources/icons/pull-request.png",
-          "visibility": "visible"
-        },
         {
           "id": "pr:github",
           "name": "Pull Requests",
-          "when": "ReposManagerStateContext != NeedsAuthentication && !github:focusedReview && !github:createPullRequest",
+          "when": "ReposManagerStateContext != NeedsAuthentication",
           "icon": "resources/icons/pull-request.png"
         },
-        {
-          "id": "github:activePullRequest",
-          "type": "webview",
-          "name": "Active Pull Request",
-          "when": "github:focusedReview"
-        },
         {
           "id": "issues:github",
           "name": "Issues",
-          "when": "ReposManagerStateContext != NeedsAuthentication && !github:focusedReview &&!github:createPullRequest",
+          "when": "ReposManagerStateContext != NeedsAuthentication",
           "icon": "resources/icons/issues.png"
-        },
+        }
+      ],
+      "github-pull-request": [
         {
           "id": "github:createPullRequest",
           "type": "webview",
@@ -411,20 +407,27 @@
           "name": "Compare Changes",
           "when": "github:createPullRequest",
           "visibility": "visible"
+        },
+        {
+          "id": "prStatus:github",
+          "name": "Changes In Pull Request",
+          "when": "github:inReviewMode",
+          "icon": "resources/icons/pull-request.png",
+          "visibility": "visible"
+        },
+        {
+          "id": "github:activePullRequest",
+          "type": "webview",
+          "name": "Active Pull Request",
+          "when": "github:focusedReview"
         }
       ]
     },
     "commands": [
       {
         "command": "pr.create",
         "title": "Create Pull Request",
-        "icon": "$(plus)",
-        "category": "GitHub Pull Requests"
-      },
-      {
-        "command": "pr.createDraft",
-        "title": "Create Draft Pull Request",
-        "icon": "$(plus)",
+        "icon": "$(git-pull-request-create)",
         "category": "GitHub Pull Requests"
       },
       {
@@ -459,8 +462,8 @@
         "category": "GitHub Pull Requests"
       },
       {
-        "command": "pr.openPullRequestInGitHub",
-        "title": "Open Pull Request in GitHub",
+        "command": "pr.openPullRequestOnGitHub",
+        "title": "Open Pull Request on GitHub",
         "category": "GitHub Pull Requests",
         "icon": "$(globe)"
       },
@@ -470,8 +473,8 @@
         "category": "GitHub Pull Requests"
       },
       {
-        "command": "pr.openFileInGitHub",
-        "title": "Open File in GitHub",
+        "command": "pr.openFileOnGitHub",
+        "title": "Open File on GitHub",
         "category": "GitHub Pull Requests"
       },
       {
@@ -499,7 +502,8 @@
         "command": "pr.openDescription",
         "title": "View Pull Request Description",
         "category": "GitHub Pull Requests",
-        "when": "github:inReviewMode"
+        "when": "github:inReviewMode",
+        "icon": "$(note)"
       },
       {
         "command": "pr.openDescriptionToTheSide",
@@ -603,7 +607,7 @@
         "command": "pr.deleteComment",
         "title": "Delete Comment",
         "category": "GitHub Pull Requests",
-        "icon": "$(close)"
+        "icon": "$(trash)"
       },
       {
         "command": "pr.finishReview",
@@ -621,6 +625,12 @@
         "title": "Configure Remotes...",
         "category": "GitHub Pull Requests"
       },
+      {
+        "command": "pr.refreshActivePullRequest",
+        "title": "Refresh",
+        "category": "GitHub Pull Requests",
+        "icon": "$(refresh)"
+      },
       {
         "command": "issue.createIssueFromSelection",
         "title": "Create Issue From Selection",
@@ -643,7 +653,7 @@
       },
       {
         "command": "issue.openGithubPermalink",
-        "title": "Open Permalink in GitHub",
+        "title": "Open Permalink on GitHub",
         "category": "GitHub Issues"
       },
       {
@@ -763,12 +773,7 @@
       {
         "view": "github:compareChanges",
         "when": "github:noUpstream",
-        "contents": "The current branch has no upstream remote\n[Publish branch](command:git.publish)"
-      },
-      {
-        "view": "github:compareChanges",
-        "when": "github:noCommitDifference",
-        "contents": "The are no commits between the base branch and the current branch"
+        "contents": "The comparing branch has no upstream remote\n[Publish branch](command:git.publish)"
       }
     ],
     "keybindings": [
@@ -817,10 +822,6 @@
           "command": "pr.create",
           "when": "gitOpenRepositoryCount != 0 && github:authenticated"
         },
-        {
-          "command": "pr.createDraft",
-          "when": "gitOpenRepositoryCount != 0 && github:authenticated"
-        },
         {
           "command": "pr.merge",
           "when": "gitOpenRepositoryCount != 0 && github:inReviewMode"
@@ -830,15 +831,15 @@
           "when": "gitOpenRepositoryCount != 0 && github:inReviewMode"
         },
         {
-          "command": "pr.openPullRequestInGitHub",
+          "command": "pr.openPullRequestOnGitHub",
           "when": "gitOpenRepositoryCount != 0 && github:inReviewMode"
         },
         {
           "command": "pr.refreshDescription",
           "when": "gitOpenRepositoryCount != 0 && github:inReviewMode"
         },
         {
-          "command": "pr.openFileInGitHub",
+          "command": "pr.openFileOnGitHub",
           "when": "false"
         },
         {
@@ -1016,6 +1017,10 @@
         {
           "command": "issue.goToLinkedCode",
           "when": "false"
+        },
+        {
+          "command": "pr.refreshActivePullRequest",
+          "when": "false"
         }
       ],
       "view/title": [
@@ -1060,9 +1065,19 @@
           "group": "navigation@1"
         },
         {
-          "command": "pr.openPullRequestInGitHub",
+          "command": "pr.refreshActivePullRequest",
           "when": "view == github:activePullRequest && github:hasGitHubRemotes",
-          "group": "navigation"
+          "group": "navigation@1"
+        },
+        {
+          "command": "pr.openDescription",
+          "when": "view == github:activePullRequest && github:hasGitHubRemotes",
+          "group": "navigation@2"
+        },
+        {
+          "command": "pr.openPullRequestOnGitHub",
+          "when": "view == github:activePullRequest && github:hasGitHubRemotes",
+          "group": "navigation@3"
         }
       ],
       "view/item/context": [
@@ -1087,7 +1102,7 @@
           "group": "pullrequest@2"
         },
         {
-          "command": "pr.openPullRequestInGitHub",
+          "command": "pr.openPullRequestOnGitHub",
           "when": "view == pr:github && viewItem =~ /pullrequest|description/",
           "group": "pullrequest@3"
         },
@@ -1097,7 +1112,7 @@
           "group": "pullrequest@4"
         },
         {
-          "command": "pr.openFileInGitHub",
+          "command": "pr.openFileOnGitHub",
           "when": "view =~ /(pr|prStatus):github/ && viewItem =~ /filechange/"
         },
         {
@@ -1424,6 +1439,7 @@
     "tunnel": "0.0.6",
     "uuid": "^3.3.3",
     "vscode-extension-telemetry": "^0.1.3",
+    "vscode-tas-client": "^0.1.17",
     "vsls": "^0.3.967"
   },
   "optionalDependencies": {

diff --git a/package.nls.json b/package.nls.json
diff --git a/src/api/api.d.ts b/src/api/api.d.ts
@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { Uri, Event, Disposable } from 'vscode';
-import { APIState } from '../typings/git';
+import { APIState, PublishEvent } from '../typings/git';
 
 export interface InputBox {
 	value: string;
@@ -270,6 +270,7 @@ export interface IGit {
 	// Used by the actual git extension to indicate it has finished initializing state information
 	readonly state?: APIState;
 	readonly onDidChangeState?: Event<APIState>;
+	readonly onDidPublish?: Event<PublishEvent>;
 }
 
 export interface API {

diff --git a/src/api/api1.ts b/src/api/api1.ts
@@ -6,7 +6,7 @@
 import * as vscode from 'vscode';
 import { API, IGit, Repository } from './api';
 import { TernarySearchTree } from '../common/utils';
-import { APIState } from '../typings/git';
+import { APIState, PublishEvent } from '../typings/git';
 
 export class GitApiImpl implements API, IGit, vscode.Disposable {
 	private static _handlePool: number = 0;
@@ -42,6 +42,8 @@ export class GitApiImpl implements API, IGit, vscode.Disposable {
 	readonly onDidCloseRepository: vscode.Event<Repository> = this._onDidCloseRepository.event;
 	private _onDidChangeState = new vscode.EventEmitter<APIState>();
 	readonly onDidChangeState: vscode.Event<APIState> = this._onDidChangeState.event;
+	private _onDidPublish = new vscode.EventEmitter<PublishEvent>();
+	readonly onDidPublish: vscode.Event<PublishEvent> = this._onDidPublish.event;
 
 	private _disposables: vscode.Disposable[];
 	constructor() {
@@ -57,6 +59,9 @@ export class GitApiImpl implements API, IGit, vscode.Disposable {
 		if (provider.onDidChangeState) {
 			this._disposables.push(provider.onDidChangeState(e => this._onDidChangeState.fire(e)));
 		}
+		if (provider.onDidPublish) {
+			this._disposables.push(provider.onDidPublish(e => this._onDidPublish.fire(e)));
+		}
 
 		provider.repositories.forEach(repository => {
 			this._onDidOpenRepository.fire(repository);