ConnectionMaster · pull · Mar 24, 2021 · Mar 27, 2021 · Mar 31, 2021 · Apr 3, 2021
diff --git a/.dockerignore b/.dockerignore
diff --git a/.gitattributes b/.gitattributes
@@ -1,3 +1,7 @@
 # text files must be lf for golden file tests to work
 *.txt eol=lf
 *.json eol=lf
+*.py eol=lf
+*.yml eol=lf
+*.yaml eol=lf
+*.md eol=lf
diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml
@@ -0,0 +1,69 @@
+name: Bug Report
+description: Something doesn't work like it should? Tell us!
+title: "[Bug]: "
+labels: []
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this bug report!
+  - type: input
+    id: version
+    attributes:
+      label: Playwright version
+      description: Which version of of Playwright are you using?
+      placeholder: ex. 1.12.0
+    validations:
+      required: true
+  - type: dropdown
+    id: operating-system
+    attributes:
+      label: Operating system
+      multiple: true
+      description: What operating system are you running Playwright on?
+      options:
+        - Windows
+        - MacOS
+        - Linux
+  - type: dropdown
+    id: browsers
+    attributes:
+      label: What browsers are you seeing the problem on?
+      multiple: true
+      options:
+        - Chromium
+        - Firefox
+        - WebKit
+  - type: textarea
+    id: other-information
+    attributes:
+      label: Other information
+      description: ex. Python version, Linux distribution etc.
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: What happened? / Describe the bug
+      description: Also tell us, what did you expect to happen?
+      placeholder: Tell us what you see!
+    validations:
+      required: true
+  - type: textarea
+    id: reproducible
+    attributes:
+      label: Code snippet to reproduce your bug
+      description: Help us help you! Put down a short code snippet that illustrates your bug and that we can run and debug locally. This will be automatically formatted into code, so no need for backticks.
+      render: shell
+      placeholder: |
+        from playwright.sync_api import sync_playwright
+
+        with sync_playwright() as p:
+            browser = p.chromium.launch()
+            page = browser.new_page()
+            # ...
+            browser.close()
+  - type: textarea
+    id: logs
+    attributes:
+      label: Relevant log output
+      description: Please copy and paste any relevant log output like [Playwright debug logs](https://playwright.dev/docs/debug#verbose-api-logs). This will be automatically formatted into code, so no need for backticks.
+      render: shell
diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml
@@ -0,0 +1,4 @@
+contact_links:
+  - name: Join our Slack community
+    url: https://aka.ms/playwright-slack
+    about: Ask questions and discuss with other community members
diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml
@@ -0,0 +1,18 @@
+name: Feature request
+description: Request new features to be added
+title: "[Feature]: "
+labels: []
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this feature request!
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: Feature request
+      description: |
+        Let us know what functionality you'd like to see in Playwright and what is your use case.
+        Do you think others might benefit from this as well?
+    validations:
+      required: true
diff --git a/.github/ISSUE_TEMPLATE/question.yml b/.github/ISSUE_TEMPLATE/question.yml
@@ -0,0 +1,11 @@
+name: I have a question
+description: Feel free to ask us your questions!
+title: "[Question]: "
+labels: []
+body:
+  - type: textarea
+    id: question
+    attributes:
+      label: Your question
+    validations:
+      required: true
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -19,32 +19,27 @@ jobs:
     - name: Set up Python
       uses: actions/setup-python@v2
       with:
-        python-version: 3.9
-    - name: Install dependencies
+        python-version: "3.10"
+    - name: Install dependencies & browsers
       run: |
-        python -m pip install --upgrade pip
+        python -m pip install --upgrade pip wheel
         pip install -r local-requirements.txt
         pip install -e .
         python setup.py bdist_wheel
-        python -m playwright install-deps
-    - name: Install browsers
-      run: python -m playwright install
+        python -m playwright install --with-deps
     - name: Lint
-      uses: pre-commit/action@v2.0.0
+      uses: pre-commit/action@v2.0.3
     - name: Generate APIs
       run: bash scripts/update_api.sh
-    - name: Verify API is up to date
-      run: |
-        if [[ -n $(git status -s) ]]; then
-          echo "ERROR: generated code differ from the current sources:"
-          git diff
-          exit 1
-        fi
-    - name: Run reference checks
-      run: bash buildbots/test-reference-count.sh
+    - name: Verify generated API is up to date
+      run: git diff --exit-code
+
   build:
     name: Build
     timeout-minutes: 30
+    env:
+      DEBUG: pw:*
+      DEBUG_FILE: pw-log.txt
     strategy:
       fail-fast: false
       matrix:
@@ -70,40 +65,64 @@ jobs:
         - os: macos-11.0
           python-version: 3.9
           browser: webkit
+        - os: ubuntu-latest
+          python-version: '3.10'
+          browser: chromium
+        - os: windows-latest
+          python-version: '3.10'
+          browser: chromium
+        - os: macos-latest
+          python-version: '3.10'
+          browser: chromium
+        - os: macos-11.0
+          python-version: '3.10'
+          browser: chromium
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v2
     - name: Set up Python
       uses: actions/setup-python@v2
       with:
         python-version: ${{ matrix.python-version }}
-    - name: Install dependencies
+    - name: Install dependencies & browsers
       run: |
-        python -m pip install --upgrade pip
+        python -m pip install --upgrade pip wheel
         pip install -r local-requirements.txt
         pip install -e .
         python setup.py bdist_wheel
-        python -m playwright install-deps
-    - name: Install browsers
-      run: python -m playwright install
+        python -m playwright install --with-deps
     - name: Common Tests
-      run: pytest -vv tests/common --browser=${{ matrix.browser }} --timeout 90
+      run: pytest tests/common --browser=${{ matrix.browser }} --timeout 90
+    - name: Test Reference count
+      run: pytest tests/test_reference_count_async.py --browser=${{ matrix.browser }}
+    - name: Test Wheel Installation
+      run: pytest tests/test_installation.py --browser=${{ matrix.browser }}
+    - name: Test Generation Scripts
+      run: pytest tests/test_generation_scripts.py --browser=${{ matrix.browser }}
     - name: Test Sync API
       if: matrix.os != 'ubuntu-latest'
-      run: pytest -vv tests/sync --browser=${{ matrix.browser }} --timeout 90
+      run: pytest tests/sync --browser=${{ matrix.browser }} --timeout 90
     - name: Test Sync API
       if: matrix.os == 'ubuntu-latest'
-      run: xvfb-run pytest -vv tests/sync --browser=${{ matrix.browser }} --timeout 90
+      run: xvfb-run pytest tests/sync --browser=${{ matrix.browser }} --timeout 90
     - name: Test Async API
       if: matrix.os != 'ubuntu-latest'
-      run: pytest -vv tests/async --browser=${{ matrix.browser }} --timeout 90
+      run: pytest tests/async --browser=${{ matrix.browser }} --timeout 90
     - name: Test Async API
       if: matrix.os == 'ubuntu-latest'
-      run: xvfb-run pytest -vv tests/async --browser=${{ matrix.browser }} --timeout 90
+      run: xvfb-run pytest tests/async --browser=${{ matrix.browser }} --timeout 90
+    - uses: actions/upload-artifact@v2
+      if: failure()
+      with:
+        name: ${{ matrix.browser }}-${{ matrix.os }}-${{ matrix.python-version }}
+        path: pw-log.txt
 
-  stable:
+  test-stable:
     name: Stable
     timeout-minutes: 30
+    env:
+      DEBUG: pw:*
+      DEBUG_FILE: pw-log.txt
     strategy:
       fail-fast: false
       matrix:
@@ -116,59 +135,55 @@ jobs:
           browser-channel: msedge
     runs-on: ${{ matrix.os }}
     steps:
-    - name: Install Media Pack
-      if: matrix.os == 'windows-latest'
-      shell: powershell
-      run: Install-WindowsFeature Server-Media-Foundation
     - uses: actions/checkout@v2
     - name: Set up Python
       uses: actions/setup-python@v2
       with:
-        python-version: 3.8
-    - name: Install dependencies
+        python-version: "3.10"
+    - name: Install dependencies & browsers
       run: |
-        python -m pip install --upgrade pip
+        python -m pip install --upgrade pip wheel
         pip install -r local-requirements.txt
         pip install -e .
         python setup.py bdist_wheel
-        python -m playwright install-deps
-    - name: Install ffmpeg
-      run: python -m playwright install ffmpeg
+        python -m playwright install ${{ matrix.browser-channel }} --with-deps
     - name: Common Tests
-      run: pytest -vv tests/common --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
+      run: pytest tests/common --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
     - name: Test Sync API
       if: matrix.os != 'ubuntu-latest'
-      run: pytest -vv tests/sync --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
+      run: pytest tests/sync --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
     - name: Test Sync API
       if: matrix.os == 'ubuntu-latest'
-      run: xvfb-run pytest -vv tests/sync --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
+      run: xvfb-run pytest tests/sync --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
     - name: Test Async API
       if: matrix.os != 'ubuntu-latest'
-      run: pytest -vv tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
+      run: pytest tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
     - name: Test Async API
       if: matrix.os == 'ubuntu-latest'
-      run: xvfb-run pytest -vv tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
+      run: xvfb-run pytest tests/async --browser=chromium --browser-channel=${{ matrix.browser-channel }} --timeout 90
+    - uses: actions/upload-artifact@v2
+      if: failure()
+      with:
+        name: ${{ matrix.browser-channel }}-${{ matrix.os }}
+        path: pw-log.txt
 
-  test-package-installations:
-    name: Test package installations
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
+  build-conda:
+    name: Conda Build
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-20.04, macos-10.15, windows-2019]
+    runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@v2
-    - name: Set up Node.js
-      uses: actions/setup-node@v1
-      with:
-        node-version: 12.x
-    - name: Set up Python
-      uses: actions/setup-python@v2
-      with:
-        python-version: 3.8
-    - name: Install dependencies
-      run: |
-        python -m pip install --upgrade pip
-        pip install -r local-requirements.txt
-        pip install -e .
-        python setup.py bdist_wheel
-        python -m playwright install-deps
-    - name: Test package installation
-      run: bash buildbots/test-package-installations.sh
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - name: Get conda
+        uses: conda-incubator/setup-miniconda@v2
+        with:
+          python-version: 3.9
+          channels: conda-forge
+      - name: Prepare
+        run: conda install conda-build conda-verify
+      - name: Build
+        run: conda build .
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -1,29 +1,49 @@
 name: Upload Python Package
 on:
+  workflow_dispatch:
   release:
     types: [published]
 jobs:
   deploy-pypi:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Node.js
-      uses: actions/setup-node@v1
-      with:
-        node-version: 12.x
     - name: Set up Python
       uses: actions/setup-python@v2
       with:
-        python-version: 3.8
+        python-version: 3.9
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
         pip install -r local-requirements.txt
         pip install -e .
-        python setup.py bdist_wheel
+        python setup.py bdist_wheel --all
         python -m playwright install-deps
     - name: Publish package
       env:
         TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}
         TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
       run: twine upload dist/*
+
+  deploy-conda:
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+      - name: Get conda
+        uses: conda-incubator/setup-miniconda@v2
+        with:
+          python-version: 3.9
+          channels: conda-forge
+      - name: Prepare
+        run: conda install anaconda-client conda-build conda-verify
+      - name: Build and Upload
+        env:
+          ANACONDA_API_TOKEN: ${{ secrets.ANACONDA_API_TOKEN }}
+        run: |
+          conda config --set anaconda_upload yes
+          conda build --user microsoft .
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,4 @@
-playwright/__pycache__/
+**/__pycache__/
 driver/
 playwright/driver/
 playwright.egg-info/
@@ -7,7 +7,7 @@ dist/
 **/*.pyc
 env/
 htmlcov/
-.coverage
+.coverage*
 .DS_Store
 .vscode/
 .eggs