Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Jan 23, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jan 23, 2021
panva and others added 15 commits February 5, 2021 18:19
Been seeing a lot of these errors lately:

```
{
  "name": "bot",
  "hostname": "infra-rackspace-debian8-x64-1",
  "pid": 2704,
  "req_id": "081c1880-7883-11eb-88cc-b7c6efa14646",
  "identifier": "node-test-pull-request",
  "event": "end",
  "level": 20,
  "msg": "Relaying jenkins.node-test-pull-request.end to nodejs/node",
  "time": "2021-02-26T22:36:13.705Z",
  "v": 0
}
{
  "name": "bot",
  "hostname": "infra-rackspace-debian8-x64-1",
  "pid": 2704,
  "req_id": "081c1880-7883-11eb-88cc-b7c6efa14646",
  "identifier": "node-test-pull-request",
  "event": "end",
  "level": 50,
  "err": {
    "message": "Converting circular structure to JSON\n    --> starting at object with constructor 'Timeout'\n    |     property '_idlePrev' -> object with constructor 'TimersList'\n    --- property '_idleNext' closes the circle",
    "name": "TypeError",
    "stack": "TypeError: Converting circular structure to JSON\n    --> starting at object with constructor 'Timeout'\n    |     property '_idlePrev' -> object with constructor 'TimersList'\n    --- property '_idleNext' closes the circle\n    at JSON.stringify (<anonymous>)\n    at fetchWrapper (/home/iojs/github-bot/node_modules/@octokit/request/dist-node/index.js:21:32)\n    at request (/home/iojs/github-bot/node_modules/@octokit/request/dist-node/index.js:125:14)\n    at hook (/home/iojs/github-bot/node_modules/@octokit/auth-token/dist-node/index.js:30:10)\n    at /home/iojs/github-bot/node_modules/@octokit/plugin-request-log/dist-node/index.js:18:12\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process/task_queues.js:93:5)\n    at async AsyncEventEmitter.handleJenkinsRelay (/home/iojs/github-bot/scripts/event-relay.js:10:5)"
  },
  "msg": "Failed to relay jenkins.node-test-pull-request.end to nodejs/node",
  "time": "2021-02-26T22:36:13.708Z",
  "v": 0
}
```

Hinting at some kind of circular reference when serialising into JSON.

Diving into the details of the somewhat recent Jenkins -> GitHub Action
relay, the fact that we serialise the `event` object which has a
`bunyan` logger instance attached to the `.logger` property, looks like
a likely suspect for that kind of circular reference.

Since there's no value in wanting to include that `.logger` property
when serialising the `event` object, or iterating over its fields,
explicitly making that field non-enumerable makes sense from a glance.
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>
First step of removing labelling of PRs as they are opened. Only the
part actively listening for newly opened PRs gets removed now, with the
main goal of *stopping* @nodejs-github-bot from applying labels and
thereby leaving room for nodejs/node-pr-labeler GitHub Action to apply
those labels intead.

Still a lot of code that can be removed, like the actually logic of
resolving labels which has been extracted into the said GitHub Action,
but postponing that to a followup PR, when seeing the Action behaving
as expected -- if not, these changes might be reverted as a fallback.

Refs https://github.com/nodejs/node-pr-labeler
This was a very neat part of the bot at one point, but ended up creating
some noise and got disabled.

It used to try backport of patches from created & updated PRs against
the `${version}.x-staging`s and as a result, added
`lts-watch-v${version}.x` or `dont-land-on-v${version}.x` when
applicable.

When it was operationale, it tried to apply patches against Node.js
versions: 4, 6 and 7. Those version are all end-of-life now.

For the bot to try backport of patches for newer versions of Node.js,
those versions would have to be added explicitly in the bot' source code.
That has obviously not happened, assuming the reason being it wasn't
as helpful afterall.
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.19...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
This bumps many dependencies, notably url-parse to 1.5.1, addressing a
GitHub interface/`npm audit` warning.
update dependencies in package-lock.json
As labelling nodejs/node PRs has been replaced by a GitHub Action.

Refs https://github.com/nodejs/node-pr-labeler
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.0 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.0...v5.1.2)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/sindresorhus/normalize-url/releases)
- [Commits](https://github.com/sindresorhus/normalize-url/commits)

---
updated-dependencies:
- dependency-name: normalize-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…nt-5.1.2

build(deps): bump glob-parent from 5.1.0 to 5.1.2
…-url-4.5.1

build(deps): bump normalize-url from 4.5.0 to 4.5.1
@mhdawson mhdawson deleted the branch ConnectionMaster:master June 21, 2021 15:36
@mhdawson mhdawson deleted the master branch June 21, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants