[pull] master from atlassian-api:master - #46
Merged
Merged
Conversation
… files (#1662) Adds add_pull_request_inline_comment() for Bitbucket Server/Data Center REST API. Supports both RANGE (whole-file) and COMMIT (line-level) anchor-based comments with configurable line type, file type, and threaded replies via parent_id. 4 new tests covering range, commit, parent threading, and custom srcPath scenarios. Co-authored-by: mrcrysta1 <mrcrysta1@users.noreply.github.com>
Fixes TypeError on 5.0.0+ where get() no longer accepts expand=. Credit @TechVoyager. Fixes #1663.
get_page_space() passed expand='space' as a keyword argument to self.get(), but AtlassianRestAPI.get() does not accept expand as a keyword — it expects it inside a params dict. This caused a TypeError when calling get_page_space() on Confluence Server v5.0.0+. Fix by building a params dict and passing it to self.get() directly, matching the pattern used by get_page_by_id() in the same file. Fixes #1663 Co-authored-by: mrcrysta1 <mrcrysta1@users.noreply.github.com> Co-authored-by: Gonchik Tsymzhitov <gonchik.tsymzhitov@atlassiancommunity.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )