Repository navigation
Make cache directory configurable like other dirs - #237
Conversation
** Why are these changes being introduced: * Some environments deny plugins the ability to create and maintain a cache internally, but other locations (like the uploads directory) may be okay. * The plugin already allows the ability to configure the scss and css folders, so perhaps the cache directory could be treated similarly. ** Relevant ticket(s): * ConnectThink#197 ** How does this address that need: * This attempts to handle the cache directory in a similar fashion to the scss and css directory, leveraging the work already done to move those locations according to user preferences. ** Document any side effects to this change: * The Wp_Scss class uses `cache` instead of `cache_dir`, while the other folders are named `scss_dir` and `css_dir`. I've opted to leave these names intact to try and make the smallest possible change, but this may be a mistake.
|
I like the idea of |
|
Do you feel comfortable merging this as-is, or would you prefer to see a PR that implements a migration script for upgrading users? I'm not sure what sort of bandwidth I can commit to that work (I have some time, but don't know whether it will be sufficient for that piece of work). I've never looked into how WordPress plugins implement migration scripts - but I suspect the documentation is out there. Obviously I'm happy for others to build on this, as well if I can't do it. |
|
Upon further reflection. I don’t see a need for a migration script. It will default to the same value it had before. My request would be that we make the change from ‘cache’ to ‘cache_dir’ throughout the code. I still need to test out the new setting option. To see if it is best to leave as an open text field or make it a drop-down select. |
|
Merging this in, I'll test and then make any needed minor adjustments before pushing up a new version. |
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
Document any side effects to this change:
cacheinstead ofcache_dir, while the other folders are namedscss_dirandcss_dir. I've opted to leave these names intact to try and make the smallest possible change, but this may be a mistake.