Skip to content

[Feature Request] Add define('WP_SCSS_ALWAYS_RECOMPILE', true); to settings page #151

Closed

Description

@bick

I had this idea when I was installing the plugin for the millionth time on a site, I always have to google the define('WP_SCSS_ALWAYS_RECOMPILE', true); code because I don't have it written down anywhere. It'd be very convenient if on the settings page, it was written at the bottom or something. I have to use it with pretty much all dev sites.

Thanks

Activity

  1. shadoath commented on Jan 24, 2021

    @shadoath
    Collaborator

    @bick When you reference the Settings page can you be more specific? Do you want it in the readme of this repo or on the WP plugin page?

  2. aerothopter commented on Feb 8, 2021

    @aerothopter

    I'll just jump in here for my 2 cents -- I think @bick meant the WP plugin settings page. We have a similar workflow for our dev sites, and it's a pain to remember to enable the WP_SCSS_ALWAYS_RECOMPILE flag, and to disable it when we go live. It would be easier to simply have a checkbox for "Always recompile SCSS" in the WP plugin settings page.

  3. bick commented on Feb 8, 2021

    @bick
    Author

    Yeah, @shadoath I meant the plugin settings page. Having it be there as a text snippet that you can simply copy and paste would be perfect, but @aerothopter's suggestion would be even more convenient.

  4. shadoath commented on Feb 9, 2021

    @shadoath
    Collaborator

    @bick @aerothopter please take a look at #162. Currently this allows for both options. I'm thinking it could be improved if it showed if the WP_SCSS_ALWAYS_RECOMPILE flag was defined in the settings page.

  5. aerothopter commented on Feb 12, 2021

    @aerothopter

    I agree. From a UX perspective, if the WP_SCSS_ALWAYS_RECOMPILE flag was defined, then the checkbox would be disabled (i.e. locked to enabled/disabled) with a tooltip letting the user know that the setting is locked using the WP_SCSS_ALWAYS_RECOMPILE flag. And if it were not defined, the user would be able to use the checkbox as normal.

  6. shadoath commented on Feb 13, 2021

    @shadoath
    Collaborator

    Screen Shot 2021-02-12 at 17 20 35

    I think this feature is ready.
  7. self-assigned this
    on Feb 13, 2021
  8. linked a pull request that will close this issueAlways recompile setting #162on Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions