Remove the 'build' directory by default#4331
Closed
comps wants to merge 1 commit intoComplianceAsCode:masterfrom
Closed
Remove the 'build' directory by default#4331comps wants to merge 1 commit intoComplianceAsCode:masterfrom
comps wants to merge 1 commit intoComplianceAsCode:masterfrom
Conversation
Most OSS projects that use cmake let the user or a script create the directory instead of it being pre-created. While it might seems just like a convenience here, if you actually remove the directory (to make a new build) and later commit with `git commit -a', the removal of `build/.gitkeep' will be added to the commit. .gitignore does not help here as it only prevents untracked files from being added - changes in existing tracked files are still registered. While there are other local-only workarounds like git update-index --skip-worktree build/.gitkeep a cleaner solution is removing the default build dir altogether. Signed-off-by: Jiri Jaburek <jjaburek@redhat.com>
|
The inspection completed: 2 new issues |
Contributor
|
Kind Nack. This is provided for content authors and not developers who are familiar with Cmake. |
Collaborator
Author
|
The main problem I wanted to address was the removed I can re-submit the |
Contributor
@comps please do submit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most OSS projects that use cmake let the user or a script create
the directory instead of it being pre-created.
While it might seems just like a convenience here, if you actually
remove the directory (to make a new build) and later commit with
git commit -a, the removal ofbuild/.gitkeepwill be added tothe commit.
.gitignore does not help here as it only prevents untracked files
from being added - changes in existing tracked files are still
registered.
While there are other local-only workarounds like
git update-index --skip-worktree build/.gitkeep
a cleaner solution is removing the default build dir altogether.