Update run_tests_testingfarm.py logging for ATEX 0.15#14361
Merged
ggbecker merged 1 commit intoComplianceAsCode:masterfrom Feb 5, 2026
Merged
Update run_tests_testingfarm.py logging for ATEX 0.15#14361ggbecker merged 1 commit intoComplianceAsCode:masterfrom
run_tests_testingfarm.py logging for ATEX 0.15#14361ggbecker merged 1 commit intoComplianceAsCode:masterfrom
Conversation
Signed-off-by: Jiri Jaburek <comps@nomail.dom>
comps
requested review from
Mab879,
jan-cerny,
matusmarhefka and
vojtapolasek
as code owners
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
Mab879
approved these changes
Feb 4, 2026
ggbecker
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
ATEX 0.15 has changed the way logging works - it now uses a more standard
logging-module-native approach with different subsystems using different loggers, so instead of oneatexlogger, there isatex.provisioner.testingfarm,atex.orchestrator.adhoc, etc.It also re-categorized what "debug", "info" and "warning" means within the context of each subsystem, whereas previously, the importance was based on using Orchestrator only (like we do here) - messages that should have been
info()for a Provisioner weredebug().That's not true anymore, so we need to filter out unrelated
info()we don't care about, hence theOrchestratorLogFilter- alogging-native solution to the problem.Similarly, I figured we don't need the long logger names in the output, hence the different format for console vs debug log.
Rationale:
While the logging changes are the most visible part, the real benefit is a much more reliable support for test reboots, which are now two-way (test waits for disconnect from ATEX) and, in my testing, reduced a ~3% rerun rate due to EOF disconnects, down to 0%.
Fortunately, this support is free here (no extra code needed beyond upgrading ATEX version, hence this PR), but a test suite change is mandatory (RHSecurityCompliance/contest#534) along with RH-internal productization repo MR#5, with all three needing to be merged at the same time.
(This is due to us using latest Contest
mainhere in the ATEX workflow, unversioned.)Review Hints:
The changes in this PR passed for me: https://github.com/comps/scap-content/actions/runs/21679753722
I even downloaded the artifacts and verified
atex_debug.log.xzworks as expected - contains FULL debug output, at approx. 250KB of compressed log size. The console output also correctly shows just the orchestration, not low-level provisioning details.Please contact me when this is ready for immediate merging, to coordinate with the repositories mentioned above.