Add Ruff bugbears to CI and fix findings#14354
Open
Mab879 wants to merge 14 commits intoComplianceAsCode:masterfrom
Open
Add Ruff bugbears to CI and fix findings#14354Mab879 wants to merge 14 commits intoComplianceAsCode:masterfrom
Mab879 wants to merge 14 commits intoComplianceAsCode:masterfrom
Conversation
Removing Python 2 compatibility.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
Mab879
requested review from
ggbecker,
jan-cerny,
marcusburghardt,
matusmarhefka and
vojtapolasek
as code owners
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
As this might removed in optimized builds
This should make build errors a bit more useful
1. re.M to re.MULTILINE for better clarity 2. Added `count` kwarg for clarity
Adjust control flow as well.
Unused variables in loops changed in `_` for clarity.
If error happened before param_obj was set this method could have return NameError. Adding a logging line then returning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Add Ruff bugbears to CI and fix findings.
See each commit for more details.
Rationale:
Help improve code quality.