Skip to content

[Ubuntu] Enable rules for sshd dropin files for cis#14326

Open
alanmcanonical wants to merge 3 commits intoComplianceAsCode:masterfrom
alanmcanonical:sshd_dropin
Open

[Ubuntu] Enable rules for sshd dropin files for cis#14326
alanmcanonical wants to merge 3 commits intoComplianceAsCode:masterfrom
alanmcanonical:sshd_dropin

Conversation

@alanmcanonical
Copy link
Contributor

@alanmcanonical alanmcanonical commented Jan 23, 2026

Description:

  • Enable rules for sshd dropin files for cis

Rationale:

  • cis benchmark also has requirements for directory /etc/ssh/sshd_config.d

@alanmcanonical alanmcanonical requested a review from a team as a code owner January 23, 2026 14:26
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 23, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2026

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jan-cerny
jan-cerny reviewed Jan 23, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 23, 2026 •
edited
Loading

ATEX Test Results

Test artifacts have been submitted to Testing Farm.

Results: View Test Results
Workflow Run: View Workflow Details

This comment was automatically generated by the ATEX workflow.

@Mab879 Mab879 added this to the 0.1.80 milestone Jan 23, 2026
mpurg
mpurg approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@mpurg mpurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@alanmcanonical
Copy link
Contributor Author

alanmcanonical commented Jan 28, 2026

@jan-cerny Could you have a look please?

@comps
Copy link
Collaborator

comps commented Jan 28, 2026

(FTR: The ATEX CI testing passed, the error happened during some cleanup. Either ignore the fail (if possible) or rebase / force-push the PR on the current master to rerun the test using the newer workflow.)

@alanmcanonical
Include rules for sshd drop in files for Ubuntu2204
13f8417 
Signed-off-by: Alan Moore <alan.moore@canonical.com>
@alanmcanonical
Include rules for sshd drop in files for Ubuntu2404
09ee20a 
Signed-off-by: Alan Moore <alan.moore@canonical.com>
@alanmcanonical
Mark multiple lines
7ef5758 
Signed-off-by: Alan Moore <alan.moore@canonical.com>
@jan-cerny jan-cerny added the Ubuntu Ubuntu product related. label Jan 30, 2026
@alanmcanonical
Copy link
Contributor Author

alanmcanonical commented Feb 4, 2026

@jan-cerny Most checks now passed. This pr is in good shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-cerny jan-cerny jan-cerny left review comments

@mpurg mpurg mpurg approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.

Projects

None yet

Milestone

0.1.80

Development

Successfully merging this pull request may close these issues.

5 participants

@alanmcanonical @comps @mpurg @jan-cerny @Mab879