fix: add assertEquals compatibility for Python 3.12+#160
Merged
cletomartin merged 1 commit intomainfrom Jul 30, 2024
Merged
Conversation
cletomartin
requested review from
alfinkel,
drsm79,
mattwhite and
smithsz
as code owners
drsm79
previously approved these changes
Jul 30, 2024
Looks like assertEquals() has been retired from unittest.TestCase. We use `assertEqual()` now but we will allow users to use `assertEquals()` for existing checks.
cletomartin
force-pushed
the
assertEquals-compatibility
branch
from
fcf3a49 to
a11bff3
Compare
drsm79
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add assertEquals compatibility for Python 3.12+.
Why
Looks like assertEquals() has been retired from unittest.TestCase. We use
assertEqual()now but we will allow users to useassertEquals()for existing checks.How
Add a method to ComplianceCheck that points to
asserEqual().Test
Added unit tests and manually tested.