fix: Include pim:storage in WebID profile by default#2147
Open
jeswr wants to merge 3 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/jeswr/CommunitySolidServer/sessions/ea3ad43a-2928-4cbd-ad37-cde6baae892f Co-authored-by: jeswr <63333554+jeswr@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jeswr/CommunitySolidServer/sessions/3fcda0b2-1d90-444e-bf09-844b1fd68166 Co-authored-by: jeswr <63333554+jeswr@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates newly generated WebID profile documents so Solid clients can discover the pod’s root storage container via a default pim:storage statement (per the expectation discussed in issue #910).
Changes:
- Add
pim:storage <{{base.path}}>to the default WebID profile Turtle template. - Extend the internal
PIMvocabulary helper with thestoragepredicate. - Add an integration test asserting the generated WebID profile contains the expected
pim:storagetriple.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/integration/Accounts.test.ts | Verifies the profile document contains a pim:storage triple pointing at the created pod root. |
| templates/pod/base/profile/card$.ttl.hbs | Adds the pim: prefix and emits pim:storage in the generated WebID profile. |
| src/util/Vocabularies.ts | Adds storage to the PIM vocabulary export for consistent predicate access. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📁 Related issues
Closes #910
✍️ Description
Adds a default
pim:storagestatement to newly generated WebID profile documents so Solid clients can discover the pod’s root storage container directly from the profile.As noted in #910 - unless there is a reason to omit the
pim:storagedeclaration on the basis of user privacy - the entity managing a WebID SHOULD include declare thepim:storagefor any storages owned by the user.✅ PR check list
Before this pull request can be merged, a core maintainer will check whether
@joachimvh - please let me know if you consider this a feature rather than a patch, in which case I can target against
versions/next-majorand add a release note.