Conversation
TallTed
suggested changes
Jan 7, 2025
Contributor
TallTed
left a comment
TallTed
left a comment
There was a problem hiding this comment.
Minor, human-facing, editorial
joachimvh
force-pushed
the
fix/304-headers
branch
from
56cd4fa to
c66278e
Compare
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
mrkvon
added a commit
to solidcouch/solidcouch
that referenced
this pull request
Jan 14, 2026
mrkvon
added a commit
to solidcouch/solidcouch
that referenced
this pull request
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📁 Related issues
#1959
✍️ Description
See the linked issue for details. Apparently it is easier to just return all the headers of the original response instead of returning none. No extra work is required as we already request the metadata to see if the response needs to be a 304 or not.