fix: Ensure streaming HTTP streams the whole notification in a single chunk#1932
Merged
joachimvh merged 1 commit intoCommunitySolidServer:mainfrom Aug 5, 2024
Merged
Conversation
joachimvh
approved these changes
Aug 5, 2024
Contributor
Author
|
Could |
Member
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📁 Related issues
✍️ Description
I have been getting notifications where most of the turtle is in one chunk, and the final
.is in a separate chunk.By using
readableToString,the HTTP stream is chunked independently of chunks onrepresentation.data.The requirement to have the full notification in a single chunk is not yet in the spec, but I'm tracking it in:
✅ PR check list
Before this pull request can be merged, a core maintainer will check whether