Skip to content

Make delimiter encoding case-insensitive #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joachimvh merged 1 commit into from
Apr 25, 2022
Merged

Make delimiter encoding case-insensitive #1273

joachimvh merged 1 commit into from
Apr 25, 2022

Conversation

@RubenVerborgh
Copy link
Member

@RubenVerborgh RubenVerborgh commented Apr 21, 2022 •
edited
Loading

…that was a wild ride. Observation and solution path via @bourgeoa.

@RubenVerborgh RubenVerborgh added the semver.patch Does not require a minor or major version bump label Apr 21, 2022
@RubenVerborgh RubenVerborgh mentioned this pull request Apr 21, 2022
Closed
@RubenVerborgh RubenVerborgh force-pushed the fix/pathdelimitercase branch 2 times, most recently from c6e7ee6 to 3459fcb Compare April 22, 2022 00:06
joachimvh
joachimvh reviewed Apr 22, 2022
View reviewed changes
wkerckho
wkerckho approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@wkerckho wkerckho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the updated PathUtil.ts, no comments from me!

@RubenVerborgh RubenVerborgh force-pushed the fix/pathdelimitercase branch from 3459fcb to ca1dd93 Compare April 22, 2022 09:20
@RubenVerborgh
Copy link
Member Author

RubenVerborgh commented Apr 22, 2022

Now with extra %-sequence encoding just because we can. And need to.

@RubenVerborgh RubenVerborgh requested a review from joachimvh April 22, 2022 09:21
@RubenVerborgh RubenVerborgh force-pushed the fix/pathdelimitercase branch from ca1dd93 to 744dd0f Compare April 22, 2022 09:23
bourgeoa
bourgeoa suggested changes Apr 23, 2022
View reviewed changes
@joachimvh joachimvh merged commit 50469e2 into main Apr 25, 2022
@joachimvh joachimvh deleted the fix/pathdelimitercase branch April 25, 2022 08:09
@wkerckho wkerckho mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wkerckho wkerckho wkerckho approved these changes

@joachimvh joachimvh joachimvh approved these changes

+1 more reviewer

@bourgeoa bourgeoa bourgeoa requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver.patch Does not require a minor or major version bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RubenVerborgh @wkerckho @bourgeoa @joachimvh