Skip to content

Warn about UnsecureWebSocketsProtocol#1248

Merged
joachimvh merged 4 commits intoversions/4.0.0from
feat/buffer-lazy-logging
Apr 1, 2022
Merged

Warn about UnsecureWebSocketsProtocol#1248
joachimvh merged 4 commits intoversions/4.0.0from
feat/buffer-lazy-logging

Conversation

@RubenVerborgh
Copy link
Member

@RubenVerborgh RubenVerborgh commented Mar 30, 2022 •
edited
Loading

…and allow logging within constructors in general.

WIP for #1220

FYI @rubensworks

@RubenVerborgh RubenVerborgh added the ☀️ enhancement New feature or request label Mar 30, 2022
@RubenVerborgh RubenVerborgh requested a review from joachimvh March 30, 2022 12:13
@RubenVerborgh RubenVerborgh mentioned this pull request Mar 30, 2022
Open
3 tasks
@RubenVerborgh RubenVerborgh force-pushed the feat/buffer-lazy-logging branch from 358cd80 to a9394c9 Compare March 30, 2022 12:58
@RubenVerborgh RubenVerborgh added this to the v4.0.0 milestone Mar 30, 2022
joachimvh
joachimvh requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@joachimvh joachimvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should target the 4.0.0 branch as we only want to start throwing warnings in that version.

@RubenVerborgh RubenVerborgh force-pushed the feat/buffer-lazy-logging branch from a9394c9 to 339f904 Compare March 31, 2022 18:06
@RubenVerborgh RubenVerborgh changed the base branch from main to versions/4.0.0 March 31, 2022 18:06
@RubenVerborgh RubenVerborgh force-pushed the feat/buffer-lazy-logging branch from 339f904 to 01ec5c7 Compare March 31, 2022 18:07
@RubenVerborgh RubenVerborgh requested a review from joachimvh April 1, 2022 06:59
@RubenVerborgh RubenVerborgh self-assigned this Apr 1, 2022
@RubenVerborgh RubenVerborgh force-pushed the feat/buffer-lazy-logging branch from 01ec5c7 to a200157 Compare April 1, 2022 07:33
@RubenVerborgh
Copy link
Member Author

RubenVerborgh commented Apr 1, 2022

Now with More Types™!

@RubenVerborgh RubenVerborgh force-pushed the feat/buffer-lazy-logging branch from a200157 to 3d66828 Compare April 1, 2022 09:38
@RubenVerborgh
Copy link
Member Author

RubenVerborgh commented Apr 1, 2022

And en passant made Logger an interface. Without meta. Signing off 😅

joachimvh
joachimvh approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@joachimvh joachimvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for old code cleanup.

@RubenVerborgh RubenVerborgh force-pushed the feat/buffer-lazy-logging branch from 3d66828 to 69477d0 Compare April 1, 2022 11:47
@joachimvh joachimvh merged commit 3685b7c into versions/4.0.0 Apr 1, 2022
@joachimvh joachimvh deleted the feat/buffer-lazy-logging branch April 1, 2022 12:19
@joachimvh joachimvh mentioned this pull request May 3, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joachimvh joachimvh joachimvh approved these changes

Assignees

@joachimvh joachimvh

Labels

☀️ enhancement New feature or request

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@RubenVerborgh @joachimvh