Skip to content

improve LockStorage and BackendKeyValueStorage #2111

@elf-pavlik

Description

@elf-pavlik

Environment

  • Server version: 8.0.0-alpha.1
  • Node.js version: v25.2.1
  • npm version: 11.6.2

Description

This is not a bug but neither a future request. Pretty much suggestion to improve configs.

It looks like LockStorage and BackendKeyValueStorage are only used with memory locks.

Filesystem has a default location in a constructor https://github.com/CommunitySolidServer/CommunitySolidServer/blob/versions/next-major/src/util/locking/FileSystemResourceLocker.ts#L88

And Redis seems to use prefixes
https://github.com/CommunitySolidServer/CommunitySolidServer/blob/versions/next-major/src/util/locking/RedisLocker.ts#L16-L18

Until something else uses LockStorage it might be better to just create it directly in
config/util/resource-locker/memory.json

Currently configuring not in-memory urn:solid-server:default:KeyValueStorage with in-memory urn:solid-server:default:BackendKeyValueStorage (just for memory locks) requires bit extra configuration.

Based on a quick matrix chat, I understood that this one doesn't seem to make much sense any more

"@id": "urn:solid-server:default:BackendKeyValueStorage",

https://matrix.to/#/!FYRTVjiUaXQvzzfwZM:gitter.im/$7P_0QOoqvxdYsttvg75DApN6XIYXXumJ5E7U3oCXdkY?via=gitter.im&via=matrix.org&via=beeper.com

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions