Conversation
…ot fully testing, the only current learner does take real[] as input and produces a single real value.
| * @param args | ||
| * @throws IOException | ||
| */ | ||
| public static void main(String[] args) throws IOException { |
There was a problem hiding this comment.
Shouldn't we move this example next to other lbjava examples, under lbjava-examples?
There was a problem hiding this comment.
@danyaljj I could put this in examples, but most of the stuff in there is LBJava. This is really something I used to test the NN locally, without LBJava. I could move this to examples, or I could convert to LBJava (this would take some time), or I could just leave it where it is. I don't think it hurts to just leave it.
There was a problem hiding this comment.
I think the library code purely the code that's being used for creating/training models and it doesn't contain any examples. I'd prefer if we move the example (especially NNBrownClassifier.lbj to the examples module).
There was a problem hiding this comment.
Ah, sorry, I was misunderstanding, I thought you wanted this main method moved. Yes, you are right, I will move that.
There was a problem hiding this comment.
I have moved the LBJava file, and all files only used by this example into the lbjava-examples project.
…. Updates the poms to 1.3.1.
| @@ -3,7 +3,7 @@ | |||
| <parent> | |||
There was a problem hiding this comment.
Sorry for being nitpicky. Would be great if you add a readme file for lbjava-examples/src/main/java/edu/illinois/cs/cogcomp/lbjava/examples/neuralnet/, explaining what is input/output, where to get the data, and what to expect after running the system.
|
@danyaljj Any idea what's going on with Semaphore? |
|
Had to start it manually for some reason (maybe because the branch was old). Should be good now. |
|
Unfortunately, the build failed, it seems to be unable to find the lbjava plugin??? Works when I build on my machine. |
|
On your machine, can you try testing it, after cleaning your maven cache. |
|
I am going to merge this before something else breaks! |
2 participants
Attempt to merge the neural net branch into the master. Please feel free to try this against any training data you might have.