Allow default boundary and capacity #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase from CodingTrain
"found 17 vulnerabilities (2 low, 14 moderate, 1 high) in 1414 scanned packages"
Member
|
What if we call this something like QuadTree.create(); // defaults but throws error message if no p5?
QuadTree.create(x, y, w, h); // boundary with default capacity
QuadTree.create(new Rectangle(x, y, w, h), capacity); // for someone who wants full customization?And maybe we should namespace everything? Thank you so so much fo taking a look at this! |
Contributor
Author
|
Made the updates to support multiple different create functions, getting to the point that I think some more solid documentation needs to get put together. I'll take a look at that later this week. Raised a new issue for the namespace item ( #38 ) |
added 2 commits
March 3, 2019 14:59
… some of the tests out Added a test case that helps fill out coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for a static withDefault() function that will attempt to pull defaults from global variables
Updated the visualize_qtree example to take advantage of this
Also updated dependencies to remove known security vulnerabilities (See commit messages)