Fix false positive about return type when there's =delete in operator= declaration

Dmitry-Me · danmar · commit f926958acb3b · 2014-11-25T15:52:52.000+01:00
diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp
@@ -1118,6 +1118,9 @@ void CheckClass::operatorEq()
 
         for (func = scope->functionList.begin(); func != scope->functionList.end(); ++func) {
             if (func->type == Function::eOperatorEqual && func->access != Private) {
+                // skip if there's =delete in the declaration - cannot be called anyway
+                if (func->tokenDef && func->tokenDef->next() && Token::Match(func->tokenDef->next()->link(), ") const| = delete"))
+                    continue;
                 // use definition for check so we don't have to deal with qualification
                 if (!(Token::Match(func->retDef, "%type% &") && func->retDef->str() == scope->className)) {
                     // make sure we really have a copy assignment operator
diff --git a/test/testclass.cpp b/test/testclass.cpp
@@ -556,13 +556,28 @@ class TestClass : public TestFixture {
                        "};");
         ASSERT_EQUALS("[test.cpp:4]: (style) 'A::operator=' should return 'A &'.\n", errout.str());
 
+        checkOpertorEq("class A\n"
+                       "{\n"
+                       "public:\n"
+                       "    void goo() {}"
+                       "    void operator=(const A&)=delete;\n"
+                       "};");
+        ASSERT_EQUALS("", errout.str());
+
         checkOpertorEq("class A\n"
                        "{\n"
                        "private:\n"
                        "    void operator=(const A&);\n"
                        "};");
         ASSERT_EQUALS("", errout.str());
 
+        checkOpertorEq("class A\n"
+                       "{\n"
+                       "private:\n"
+                       "    void operator=(const A&)=delete;\n"
+                       "};");
+        ASSERT_EQUALS("", errout.str());
+
         checkOpertorEq("class A\n"
                        "{\n"
                        "    void operator=(const A&);\n"
@@ -596,6 +611,12 @@ class TestClass : public TestFixture {
                        "    void operator=(const A&);\n"
                        "};");
         ASSERT_EQUALS("[test.cpp:3]: (style) 'A::operator=' should return 'A &'.\n", errout.str());
+
+        checkOpertorEq("struct A\n"
+                       "{\n"
+                       "    void operator=(const A&)=delete;\n"
+                       "};");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void operatorEq2() {
