feat(roll): roll Playwright 1.15.0-next-1629385562000 (microsoft#854)

mxschmitt · web-flow · commit c4a38ab0365c · 2021-08-19T23:46:04.000+02:00
diff --git a/playwright/_impl/_browser.py b/playwright/_impl/_browser.py
@@ -106,6 +106,7 @@ async def new_context(
         recordVideoSize: ViewportSize = None,
         storageState: Union[StorageState, str, Path] = None,
         baseURL: str = None,
+        strictSelectors: bool = None,
     ) -> BrowserContext:
         params = locals_to_params(locals())
         await normalize_context_params(self._connection._is_sync, params)
@@ -147,6 +148,7 @@ async def new_page(
         recordVideoSize: ViewportSize = None,
         storageState: Union[StorageState, str, Path] = None,
         baseURL: str = None,
+        strictSelectors: bool = None,
     ) -> Page:
         params = locals_to_params(locals())
         context = await self.new_context(**params)
diff --git a/playwright/_impl/_browser_context.py b/playwright/_impl/_browser_context.py
@@ -28,6 +28,7 @@
     from_nullable_channel,
 )
 from playwright._impl._event_context_manager import EventContextManagerImpl
+from playwright._impl._frame import Frame
 from playwright._impl._helper import (
     RouteHandler,
     RouteHandlerEntry,
@@ -38,6 +39,7 @@
     async_writefile,
     is_safe_close_error,
     locals_to_params,
+    to_impl,
 )
 from playwright._impl._network import Request, Response, Route, serialize_headers
 from playwright._impl._page import BindingCall, Page, Worker
@@ -368,10 +370,16 @@ def background_pages(self) -> List[Page]:
     def service_workers(self) -> List[Worker]:
         return list(self._service_workers)
 
-    async def new_cdp_session(self, page: Page) -> CDPSession:
-        return from_channel(
-            await self._channel.send("newCDPSession", {"page": page._channel})
-        )
+    async def new_cdp_session(self, page: Union[Page, Frame]) -> CDPSession:
+        page = to_impl(page)
+        params = {}
+        if isinstance(page, Page):
+            params["page"] = page._channel
+        elif isinstance(page, Frame):
+            params["frame"] = page._channel
+        else:
+            raise Error("page: expected Page or Frame")
+        return from_channel(await self._channel.send("newCDPSession", params))
 
     @property
     def tracing(self) -> Tracing:
diff --git a/playwright/_impl/_browser_type.py b/playwright/_impl/_browser_type.py
@@ -133,6 +133,7 @@ async def launch_persistent_context(
         recordVideoDir: Union[Path, str] = None,
         recordVideoSize: ViewportSize = None,
         baseURL: str = None,
+        strictSelectors: bool = None,
     ) -> BrowserContext:
         userDataDir = str(Path(userDataDir))
         params = locals_to_params(locals())
diff --git a/playwright/_impl/_helper.py b/playwright/_impl/_helper.py
@@ -29,6 +29,7 @@
     List,
     Optional,
     Pattern,
+    TypeVar,
     Union,
     cast,
 )
@@ -254,3 +255,12 @@ def inner() -> bytes:
 
     loop = asyncio.get_running_loop()
     return await loop.run_in_executor(None, inner)
+
+
+T = TypeVar("T")
+
+
+def to_impl(obj: T) -> T:
+    if hasattr(obj, "_impl_obj"):
+        return cast(Any, obj)._impl_obj
+    return obj
diff --git a/playwright/async_api/_generated.py b/playwright/async_api/_generated.py
@@ -3999,8 +3999,6 @@ def locator(self, selector: str) -> "Locator":
         element immediately before performing an action, so a series of actions on the same locator can in fact be performed on
         different DOM elements. That would happen if the DOM structure between those actions has changed.
 
-        Note that locator always implies visibility, so it will always be locating visible elements.
-
         Parameters
         ----------
         selector : str
@@ -7344,8 +7342,6 @@ def locator(self, selector: str) -> "Locator":
         element immediately before performing an action, so a series of actions on the same locator can in fact be performed on
         different DOM elements. That would happen if the DOM structure between those actions has changed.
 
-        Note that locator always implies visibility, so it will always be locating visible elements.
-
         Shortcut for main frame's `frame.locator()`.
 
         Parameters
@@ -9469,7 +9465,9 @@ def expect_page(
             ).future
         )
 
-    async def new_cdp_session(self, page: "Page") -> "CDPSession":
+    async def new_cdp_session(
+        self, page: typing.Union["Page", "Frame"]
+    ) -> "CDPSession":
         """BrowserContext.new_cdp_session
 
         > NOTE: CDP sessions are only supported on Chromium-based browsers.
@@ -9478,8 +9476,9 @@ async def new_cdp_session(self, page: "Page") -> "CDPSession":
 
         Parameters
         ----------
-        page : Page
-            Page to create new session for.
+        page : Union[Frame, Page]
+            Target to create new session for. For backwards-compatability, this parameter is named `page`, but it can be a `Page` or
+            `Frame` type.
 
         Returns
         -------
@@ -9489,7 +9488,7 @@ async def new_cdp_session(self, page: "Page") -> "CDPSession":
         return mapping.from_impl(
             await self._async(
                 "browser_context.new_cdp_session",
-                self._impl_obj.new_cdp_session(page=page._impl_obj),
+                self._impl_obj.new_cdp_session(page=page),
             )
         )
 
@@ -9615,7 +9614,8 @@ async def new_context(
         record_video_dir: typing.Union[str, pathlib.Path] = None,
         record_video_size: ViewportSize = None,
         storage_state: typing.Union[StorageState, str, pathlib.Path] = None,
-        base_url: str = None
+        base_url: str = None,
+        strict_selectors: bool = None
     ) -> "BrowserContext":
         """Browser.new_context
 
@@ -9709,6 +9709,10 @@ async def new_context(
             Examples:
             - baseURL: `http://localhost:3000` and navigating to `/bar.html` results in `http://localhost:3000/bar.html`
             - baseURL: `http://localhost:3000/foo/` and navigating to `./bar.html` results in `http://localhost:3000/foo/bar.html`
+        strict_selectors : Union[bool, NoneType]
+            It specified, enables strict selectors mode for this context. In the strict selectors mode all operations on selectors
+            that imply single target DOM element will throw when more than one element matches the selector. See `Locator` to learn
+            more about the strict mode.
 
         Returns
         -------
@@ -9747,6 +9751,7 @@ async def new_context(
                     recordVideoSize=record_video_size,
                     storageState=storage_state,
                     baseURL=base_url,
+                    strictSelectors=strict_selectors,
                 ),
             )
         )
@@ -9781,7 +9786,8 @@ async def new_page(
         record_video_dir: typing.Union[str, pathlib.Path] = None,
         record_video_size: ViewportSize = None,
         storage_state: typing.Union[StorageState, str, pathlib.Path] = None,
-        base_url: str = None
+        base_url: str = None,
+        strict_selectors: bool = None
     ) -> "Page":
         """Browser.new_page
 
@@ -9870,6 +9876,10 @@ async def new_page(
             Examples:
             - baseURL: `http://localhost:3000` and navigating to `/bar.html` results in `http://localhost:3000/bar.html`
             - baseURL: `http://localhost:3000/foo/` and navigating to `./bar.html` results in `http://localhost:3000/foo/bar.html`
+        strict_selectors : Union[bool, NoneType]
+            It specified, enables strict selectors mode for this context. In the strict selectors mode all operations on selectors
+            that imply single target DOM element will throw when more than one element matches the selector. See `Locator` to learn
+            more about the strict mode.
 
         Returns
         -------
@@ -9908,6 +9918,7 @@ async def new_page(
                     recordVideoSize=record_video_size,
                     storageState=storage_state,
                     baseURL=base_url,
+                    strictSelectors=strict_selectors,
                 ),
             )
         )
@@ -10218,7 +10229,8 @@ async def launch_persistent_context(
         record_har_omit_content: bool = None,
         record_video_dir: typing.Union[str, pathlib.Path] = None,
         record_video_size: ViewportSize = None,
-        base_url: str = None
+        base_url: str = None,
+        strict_selectors: bool = None
     ) -> "BrowserContext":
         """BrowserType.launch_persistent_context
 
@@ -10345,6 +10357,10 @@ async def launch_persistent_context(
             Examples:
             - baseURL: `http://localhost:3000` and navigating to `/bar.html` results in `http://localhost:3000/bar.html`
             - baseURL: `http://localhost:3000/foo/` and navigating to `./bar.html` results in `http://localhost:3000/foo/bar.html`
+        strict_selectors : Union[bool, NoneType]
+            It specified, enables strict selectors mode for this context. In the strict selectors mode all operations on selectors
+            that imply single target DOM element will throw when more than one element matches the selector. See `Locator` to learn
+            more about the strict mode.
 
         Returns
         -------
@@ -10397,6 +10413,7 @@ async def launch_persistent_context(
                     recordVideoDir=record_video_dir,
                     recordVideoSize=record_video_size,
                     baseURL=base_url,
+                    strictSelectors=strict_selectors,
                 ),
             )
         )
@@ -11009,7 +11026,7 @@ async def evaluate(
         Examples:
 
         ```py
-        tweets = await page.locator(\".tweet .retweets\")
+        tweets = page.locator(\".tweet .retweets\")
         assert await tweets.evaluate(\"node => node.innerText\") == \"10 retweets\"
         ```
 
diff --git a/playwright/sync_api/_generated.py b/playwright/sync_api/_generated.py
@@ -3977,8 +3977,6 @@ def locator(self, selector: str) -> "Locator":
         element immediately before performing an action, so a series of actions on the same locator can in fact be performed on
         different DOM elements. That would happen if the DOM structure between those actions has changed.
 
-        Note that locator always implies visibility, so it will always be locating visible elements.
-
         Parameters
         ----------
         selector : str
@@ -7299,8 +7297,6 @@ def locator(self, selector: str) -> "Locator":
         element immediately before performing an action, so a series of actions on the same locator can in fact be performed on
         different DOM elements. That would happen if the DOM structure between those actions has changed.
 
-        Note that locator always implies visibility, so it will always be locating visible elements.
-
         Shortcut for main frame's `frame.locator()`.
 
         Parameters
@@ -9410,7 +9406,7 @@ def expect_page(
             ).future,
         )
 
-    def new_cdp_session(self, page: "Page") -> "CDPSession":
+    def new_cdp_session(self, page: typing.Union["Page", "Frame"]) -> "CDPSession":
         """BrowserContext.new_cdp_session
 
         > NOTE: CDP sessions are only supported on Chromium-based browsers.
@@ -9419,8 +9415,9 @@ def new_cdp_session(self, page: "Page") -> "CDPSession":
 
         Parameters
         ----------
-        page : Page
-            Page to create new session for.
+        page : Union[Frame, Page]
+            Target to create new session for. For backwards-compatability, this parameter is named `page`, but it can be a `Page` or
+            `Frame` type.
 
         Returns
         -------
@@ -9430,7 +9427,7 @@ def new_cdp_session(self, page: "Page") -> "CDPSession":
         return mapping.from_impl(
             self._sync(
                 "browser_context.new_cdp_session",
-                self._impl_obj.new_cdp_session(page=page._impl_obj),
+                self._impl_obj.new_cdp_session(page=page),
             )
         )
 
@@ -9556,7 +9553,8 @@ def new_context(
         record_video_dir: typing.Union[str, pathlib.Path] = None,
         record_video_size: ViewportSize = None,
         storage_state: typing.Union[StorageState, str, pathlib.Path] = None,
-        base_url: str = None
+        base_url: str = None,
+        strict_selectors: bool = None
     ) -> "BrowserContext":
         """Browser.new_context
 
@@ -9650,6 +9648,10 @@ def new_context(
             Examples:
             - baseURL: `http://localhost:3000` and navigating to `/bar.html` results in `http://localhost:3000/bar.html`
             - baseURL: `http://localhost:3000/foo/` and navigating to `./bar.html` results in `http://localhost:3000/foo/bar.html`
+        strict_selectors : Union[bool, NoneType]
+            It specified, enables strict selectors mode for this context. In the strict selectors mode all operations on selectors
+            that imply single target DOM element will throw when more than one element matches the selector. See `Locator` to learn
+            more about the strict mode.
 
         Returns
         -------
@@ -9688,6 +9690,7 @@ def new_context(
                     recordVideoSize=record_video_size,
                     storageState=storage_state,
                     baseURL=base_url,
+                    strictSelectors=strict_selectors,
                 ),
             )
         )
@@ -9722,7 +9725,8 @@ def new_page(
         record_video_dir: typing.Union[str, pathlib.Path] = None,
         record_video_size: ViewportSize = None,
         storage_state: typing.Union[StorageState, str, pathlib.Path] = None,
-        base_url: str = None
+        base_url: str = None,
+        strict_selectors: bool = None
     ) -> "Page":
         """Browser.new_page
 
@@ -9811,6 +9815,10 @@ def new_page(
             Examples:
             - baseURL: `http://localhost:3000` and navigating to `/bar.html` results in `http://localhost:3000/bar.html`
             - baseURL: `http://localhost:3000/foo/` and navigating to `./bar.html` results in `http://localhost:3000/foo/bar.html`
+        strict_selectors : Union[bool, NoneType]
+            It specified, enables strict selectors mode for this context. In the strict selectors mode all operations on selectors
+            that imply single target DOM element will throw when more than one element matches the selector. See `Locator` to learn
+            more about the strict mode.
 
         Returns
         -------
@@ -9849,6 +9857,7 @@ def new_page(
                     recordVideoSize=record_video_size,
                     storageState=storage_state,
                     baseURL=base_url,
+                    strictSelectors=strict_selectors,
                 ),
             )
         )
@@ -10159,7 +10168,8 @@ def launch_persistent_context(
         record_har_omit_content: bool = None,
         record_video_dir: typing.Union[str, pathlib.Path] = None,
         record_video_size: ViewportSize = None,
-        base_url: str = None
+        base_url: str = None,
+        strict_selectors: bool = None
     ) -> "BrowserContext":
         """BrowserType.launch_persistent_context
 
@@ -10286,6 +10296,10 @@ def launch_persistent_context(
             Examples:
             - baseURL: `http://localhost:3000` and navigating to `/bar.html` results in `http://localhost:3000/bar.html`
             - baseURL: `http://localhost:3000/foo/` and navigating to `./bar.html` results in `http://localhost:3000/foo/bar.html`
+        strict_selectors : Union[bool, NoneType]
+            It specified, enables strict selectors mode for this context. In the strict selectors mode all operations on selectors
+            that imply single target DOM element will throw when more than one element matches the selector. See `Locator` to learn
+            more about the strict mode.
 
         Returns
         -------
@@ -10338,6 +10352,7 @@ def launch_persistent_context(
                     recordVideoDir=record_video_dir,
                     recordVideoSize=record_video_size,
                     baseURL=base_url,
+                    strictSelectors=strict_selectors,
                 ),
             )
         )
diff --git a/setup.py b/setup.py
@@ -28,7 +28,7 @@
     InWheel = None
 from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand
 
-driver_version = "1.14.0-1628783206000"
+driver_version = "1.15.0-next-1629385562000"
 
 
 def extractall(zip: zipfile.ZipFile, path: str) -> None:
diff --git a/tests/async/test_browsercontext.py b/tests/async/test_browsercontext.py
diff --git a/tests/async/test_cdp_session.py b/tests/async/test_cdp_session.py
