Undo#20
Merged
Merged
Conversation
Reverts to 0.4.3 behavior of all worlds in $WORLDS_DIR will be copied to ramdisk. It was causing confusion. I'll find an easier way to implement it later. Minor: Cleaned up console messages. Set tmpfs to default example in minecraft.conf Removed RD_WORLD_DIR in minecraft.conf Signed-off-by: J.C. Doll <sjdoll@gmail.com>
Member
|
Yeah, this one is something that can be merged automatically. :D Personally, I like being able to selectively load worlds into ramdisk. Though I'll agree that currently it can be a tad confusing. I think that if we ever make an install script, we could put a function in there that parses the worlds folder and outputs a list of worlds to a file, where people can choose which worlds should be loaded into the ramdisk and which ones shouldn't. For example, you might run './install.sh scanworlds' or something. I dunno. It's something we can work on later. Before that, there's some bug fixing to do and rsync to implement. |
dghodgson
added a commit
that referenced
this pull request
May 4, 2012
Revert the script back to 0.4.3 behavior of copying all worlds in $WORLDS_DIR to the ramdisk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will revert the script back to 0.4.3 behavior of copying all worlds in $WORLDS_DIR to the ramdisk.
Having ramworlds and worlds was causing confusion. I'll find an easier way to implement it later. Maybe an array.
Minor changes:
Cleaned up console messages.
Set tmpfs to default example in minecraft.conf
Removed RD_WORLD_DIR in minecraft.conf
I just ran through basic testing on my development server (CentOS 6.2). My production script is going to be out of sync for now, since I need the feature.
The one thing I did not test, was restarting Linux while the CraftBukkit server was running to see if I needed to change the lockfile path back to /var/lock/subsys for Red Hat Distro's.
I hope this goes better than my last pull request.