Improved support for Codeception 5/PHP 8 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesdevnull
commented
Feb 9, 2022
Contributor
Author
yesdevnull
left a comment
yesdevnull
left a comment
There was a problem hiding this comment.
Same comment re composer.json as Codeception/module-symfony#154 (review).
Member
|
LGTM so far. |
yesdevnull
force-pushed
the
codecept5
branch
from
a1355b3 to
abba58a
Compare
TavoNiievez
reviewed
Feb 11, 2022
TavoNiievez
approved these changes
Feb 11, 2022
yesdevnull
force-pushed
the
codecept5
branch
from
abba58a to
ea916d9
Compare
TavoNiievez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to do the following:
composer.jsonchanges with other Codeception modules.Bonus points (for a separate PR maybe):
module-doctrine2)