-
Notifications
You must be signed in to change notification settings - Fork 134
Add phar build command for codeception 5.3 #898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@W0rma I'm not familiar with the phar release management, but the readme might need some adjustment as well to include commands for the PHP 8.2/Codeception 5.3 release: codeception.github.com/package/README.md Line 24 in dc29cb9
|
You are right. I adjusted the file. |
package/README.md
Outdated
| 2. Run `./vendor/bin/robo release80` | ||
| 5. Commit added files and push | ||
| 5. Build Codeception 5.3 phar file | ||
| 1. Run `./vendor/bin/robo build:phar82` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you decide to keep the command for PHP 8.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no specific reason. I just noticed that the other commands for older versions are still listed, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An outdated logic that I believe we should not maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the phar build commands for codeception < 5.3
This PR adds the commands
build:phar82andrelease82as proposed in Codeception/Codeception#6864 (comment)