Skip to content

Conversation

@W0rma
Copy link
Contributor

@W0rma W0rma commented Dec 20, 2025

This PR adds the commands build:phar82 and release82 as proposed in Codeception/Codeception#6864 (comment)

@W0rma W0rma marked this pull request as ready for review December 20, 2025 12:47
@burned42
Copy link

@W0rma I'm not familiar with the phar release management, but the readme might need some adjustment as well to include commands for the PHP 8.2/Codeception 5.3 release:

4. Build Codeception 5 phar file:

@W0rma
Copy link
Contributor Author

W0rma commented Dec 20, 2025

the readme might need some adjustment as well to include commands for the PHP 8.2/Codeception 5.3 release:

You are right. I adjusted the file.

Comment on lines 26 to 28
2. Run `./vendor/bin/robo release80`
5. Commit added files and push
5. Build Codeception 5.3 phar file
1. Run `./vendor/bin/robo build:phar82`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you decide to keep the command for PHP 8.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no specific reason. I just noticed that the other commands for older versions are still listed, too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An outdated logic that I believe we should not maintain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the phar build commands for codeception < 5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants