Update AdvancedUsage.md: Before/After improvements #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page: https://codeception.com/docs/AdvancedUsage#BeforeAfter-Attributes This is the most important change: > The referenced method needs to be in the same class as the public function. I took the info from here: https://github.com/Codeception/Codeception/blob/main/src/Codeception/Subscriber/BeforeAfterTest.php#L49 - please doublecheck.
ThomasLandauer
changed the title
TavoNiievez
reviewed
Nov 27, 2025
| protected function login(AcceptanceTester $I) | ||
| final class ModeratorCest | ||
| { | ||
| protected function login(FunctionalTester $I): void |
Member
There was a problem hiding this comment.
I can't remember if the scenarios are generated with : void, so I'm not sure about this change.
Could you confirm if this is how it works and ideally link the PR where this change was added?
Thanks!
There are also conflicts that need to be resolved.
Member
Author
There was a problem hiding this comment.
- I found the PR: generate:cest: Adding
declare(strict_types=1);and return typevoidto generated files Codeception#6736 - Conflicts: I hope I didn't mess it up now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page: https://codeception.com/docs/AdvancedUsage#BeforeAfter-Attributes
This is the most important change:
I took the info from here: https://github.com/Codeception/Codeception/blob/main/src/Codeception/Subscriber/BeforeAfterTest.php#L49 - please doublecheck.