Skip to content

Allow multiple test dependencies - 2#6835

Open
christianlerch wants to merge 1 commit intoCodeception:mainfrom
christianlerch:fix/multiple-depends
Open

Allow multiple test dependencies - 2#6835
christianlerch wants to merge 1 commit intoCodeception:mainfrom
christianlerch:fix/multiple-depends

Conversation

@christianlerch
Copy link

In #6676, a fix has been made that allows for multiple Depends. It seems that two other places have a similar logic which have been forgotten.

The exception I got
Fatal error: Uncaught TypeError: str_contains(): Argument #1 ($haystack) must be of type string, array given in /data/vendor/codeception/codeception/src/Codeception/Test/TestCaseWrapper.php:96
Stack trace:
#0 /data/vendor/codeception/codeception/src/Codeception/Test/TestCaseWrapper.php(96): str_contains(Array, ':')
#1 /data/vendor/codeception/codeception/src/Codeception/Suite.php(157): Codeception\Test\TestCaseWrapper->fetchDependencies()
#2 /data/vendor/codeception/codeception/src/Codeception/Suite.php(136): Codeception\Suite->getDependencies(Object(Codeception\Test\TestCaseWrapper))
#3 /data/vendor/codeception/codeception/src/Codeception/SuiteManager.php(93): Codeception\Suite->reorderDependencies()
#4 /data/vendor/codeception/codeception/src/Codeception/Codecept.php(251): Codeception\SuiteManager->loadTests(NULL)
#5 /data/vendor/codeception/codeception/src/Codeception/Codecept.php(209): Codeception\Codecept->runSuite(Array, 'Business', NULL)
#6 /data/vendor/codeception/codeception/src/Codeception/Command/Run.php(576): Codeception\Codecept->run('Business')
#7 /data/vendor/codeception/codeception/src/Codeception/Command/Run.php(541): Codeception\Command\Run->runSuites(Array, Array)
#8 /data/vendor/codeception/codeception/src/Codeception/Command/Run.php(416): Codeception\Command\Run->runIncludedSuites(Array, '/data/', Array, Array)
#9 /data/vendor/symfony/console/Command/Command.php(298): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 /data/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 /data/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#12 /data/vendor/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#13 /data/vendor/codeception/codeception/src/Codeception/Application.php(112): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#14 /data/vendor/codeception/codeception/app.php(45): Codeception\Application->run()
#15 /data/vendor/codeception/codeception/app.php(46): {closure}()
#16 /data/vendor/codeception/codeception/codecept(7): require('/data/vendor/co...')
#17 /data/vendor/bin/codecept(119): include('/data/vendor/co...')
#18 {main}
  thrown in /data/vendor/codeception/codeception/src/Codeception/Test/TestCaseWrapper.php on line 96

@TavoNiievez
Copy link
Member

@christianlerch Could you please rebase?

@christianlerch
Copy link
Author

Sure, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants