[6759] Add separate errors tab in HTML report (redirected to 'main')#6790
Open
sem-peters wants to merge 1 commit intoCodeception:mainfrom
Open
[6759] Add separate errors tab in HTML report (redirected to 'main')#6790sem-peters wants to merge 1 commit intoCodeception:mainfrom
sem-peters wants to merge 1 commit intoCodeception:mainfrom
Conversation
Collaborator
|
I did not even know / remember we had an HTML report, thanks for making me aware, something I'll be using soon for sure. This PR is missing some minor things:
Since we're currently not testing the
You'll need to do something like this: $reportHandle = tmpfile();
$output = ...
$reporter = new HtmlReporter(['html' => stream_get_meta_data($reportHandle)['uri']], $output);
// Test
$reporter->testUseless(...);
// Assert output
rewind($reportHandle);
$report = stream_get_contents($reportHandle);
// Assert that I see some pretty HTML error stuff. |
Author
|
Thanks for the review, I'll get on it soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(copied from #6765)
Fix for #6759
I added a separate tab for errors. I also added an internal test that errors to test the HTML reporter itself. I can imagine this is undesirable, so please let me know if I have to remove it!