London | 26-ITP-Jan | Abdul Moiz | Sprint 2 | Sprint 2 #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-Moiz
added
the
Needs Review
cjyuan
reviewed
Feb 10, 2026
|
|
||
| // =============> write your new code here | ||
| function capitalise(str) { | ||
| let newStr = `${str[0].toUpperCase()}${str.slice(1)}`; |
Contributor
There was a problem hiding this comment.
For a variable not needed to be reassigned a value, a better practice is to use const instead of let.
| } No newline at end of file | ||
| let heightSquared = height * height; | ||
| let bmi = weight / heightSquared; | ||
| return bmi.toFixed(1); |
Contributor
There was a problem hiding this comment.
What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?
Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,
console.log(123); // Output 123
console.log("123"); // Output 123
// Treated differently in the program
let sum1 = 123 + 100; // Evaluate to 223 -- a number
let sum 2 = "123" + 100; // Evaluate to "123100" -- a string.
Comment on lines
+48
to
+56
| console.assert(formatAs12HourClock("01:00") === "01:00 am"); | ||
| console.assert(formatAs12HourClock("11:59") === "11:59 am"); | ||
|
|
||
| // Noon | ||
| console.assert(formatAs12HourClock("12:00") === "12:00 pm"); | ||
| console.assert(formatAs12HourClock("12:30") === "12:30 pm"); | ||
|
|
||
| // Afternoon / evening | ||
| console.assert(formatAs12HourClock("13:00") === "1:00 pm"); |
Contributor
There was a problem hiding this comment.
Output on lines 56 and 48 have slightly different format.
Can you modify the function to return a string in a consistent format?
| // Updated function: | ||
| function formatAs12HourClock(time) { | ||
| const hours = Number(time.slice(0, 2)); | ||
| const minutes = time.slice(3, 5); |
Contributor
There was a problem hiding this comment.
Can also consider time.slice(-2) (a bit more expressive).
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all the exercises in Sprint 2 directory
Questions
N/A