Use more semantic button selectors in test #280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mandating that these buttons be <i> tags feels pretty weird. Buttons are great.
40thieves
requested changes
Jan 7, 2025
40thieves
left a comment
40thieves
left a comment
There was a problem hiding this comment.
This is an improvement, but I think we should probably switch the variable names within the test too: e.g. tickIcon -> doneBtn?
Perhaps I'm stating the obvious here, but <i class="fa-check"></i> was the recommended pattern for Font Awesome (via Bootstrap) icons - hence the naming here that appears to have got out of sync with the impl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mandating that these buttons be
<i>tags feels pretty weird. Buttons are great.