Responsive - Feature section#525
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request enhances the responsive design of the feature comparison section to better support mobile and smaller screen devices. The changes focus on improving layout, typography, and spacing across different viewport sizes.
Changes:
- Replaced inline styles with Tailwind utility classes for responsive padding in the section container
- Adjusted text sizes and spacing for better mobile readability (headings, paragraphs, badges)
- Restructured table layout with improved responsive wrapper and updated minimum width constraints
- Standardized cell padding from
p-2top-3for more balanced spacing across all table cells
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Shashankss1205 done and also this PR #503 is ready. |
|
Other comments of copilot can be ignored as they don't align with current responsive design. |
|
@Shashankss1205 PR is ready. |
Shashankss1205
left a comment
Shashankss1205
left a comment
There was a problem hiding this comment.
I dont think that this helps, the idea was to show the entire table in a single screen rather than horizontal scroll
Simplest fix would be adding image instead of table, or use cards, how would you like to proceed? |
|
I think an image would be subjected to blurring on large screens, so any other solution is preferred! |
|
Ok I'll try with card layout but it won't be horizontally aligned like it currently is, is it ok? I'll add screenshot here before final changes, or do you want it on discord? |
|
Anything works |
|
@Sahilbhatane are you still interested in making a correction to this PR? |
here how it currently looks, i tried this on 390×844 |
|
@Shashankss1205 check above screenshot and if its ok i can commit those changes, also can you add labels to the PR. |
|
Tbh it doesnt look good. any other suggestions? |
|
If we want side by side comparison then most probably this will be the best solution, but if we divide feature and for each feature have comparison (horizontal comparison) then everything will look clean,
I'll create this version as well and add a screenshot shot here |
|
@Sahilbhatane is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
|
@Shashankss1205 check Screenshot, do you like this design? i did as i suggested from earlier comment. |
|
@Shashankss1205 PR is ready to merge can you check the SS to confirm the design? also check #632 is also seems to be important issue and that PR solves it, can you check that as well |
Responsive - Feature section
Fixed issue #497, Added section padding, adjust text size, and adjust the table structure to be responsive for most of the responsive devices.