fix(platform): normalize graph relative paths to posix on Windows and… - #1356
fix(platform): normalize graph relative paths to posix on Windows and…#1356Kritika11052005 wants to merge 1 commit into
Conversation
… update parser goldens
|
@Kritika11052005 is attempting to deploy a commit to the shashankss1205's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Thanks for contributing to CodeGraphContext! Since this PR was opened, |
|
Triage update: part of what this fixes has since landed — startup sync now compares POSIX-normalized paths (#1433), which was the headline Windows deletion bug. The branch also carries a large amount of unrelated churn (+13k/−11k), which makes it unreviewable as-is. @Kritika11052005 if there are Windows normalization gaps remaining beyond #1433, could you rebase and trim this down to just those sites? A focused diff will get a fast review. 🙏 |
|
Keeping this open — the underlying fix matters — but it cannot be merged in this shape. The diff is 92 files, +13199/-11671. The stated purpose is normalising graph relative paths to POSIX on Windows, which should touch a handful of files. A change of this size cannot be reviewed for correctness, and it is currently conflicting with Most of the volume looks incidental — please check for these before re-pushing:
The bug is real and worth fixing. Path normalisation is load-bearing: the graph stores paths via If it helps, |
|
Thanks for tackling the Windows path normalisation — that's a real problem worth fixing. I can't merge this as it stands, though: the branch touches 92 files with +13,199/-11,671 and produces 85 conflict regions against current Looking at the file list ( Could you open a fresh branch from current If some of the other 90 files contain changes you want to keep, they'd be much easier to land as separate focused PRs. Two things worth knowing before you rebase:
Happy to look at a focused version quickly. If you can share the specific Windows symptom you hit (a path that comes out wrong in the graph), I can help confirm whether it still reproduces on |
Description
This PR resolves cross-platform path inconsistencies on Windows that were causing integration test regressions, fixes a process hang on exit with KuzuDB, registers missing language query toolkits, and updates the regression goldens.
Key Changes
writer.pyandgraph_builder.pyto use.as_posix()for relative path calculation. This ensures relative paths are saved using forward slashes (/) in the graph database, maintaining cross-platform consistency.database_embedded_kuzu.pyto safely verify theis_closedattribute of the Kùzu connection before invoking.close(), preventing background threads from hanging on process exit.ScalaToolkit,SwiftToolkit, andHaskellToolkitinadvanced_language_query_tool.pyto complete support for all 16 languages.--update-goldens) to reflect the normalized posix relative paths and parser improvements.test_advanced_language_query_toolkits.pyunit tests to verify proper registration and instantiation of all 16 toolkits.Verification
test_parser_goldens.pynow pass.Labels Request
Could the maintainers please add the following labels to this PR:
gssoc:approveddifficulty:medium)type:bugfix)