Skip to content

Change default http client to apache http client#1439

Merged
mzitnik merged 2 commits intomainfrom
change_default_http_client
Sep 12, 2023
Merged

Change default http client to apache http client#1439
mzitnik merged 2 commits intomainfrom
change_default_http_client

Conversation

@mzitnik
Copy link
Contributor

@mzitnik mzitnik commented Sep 5, 2023

Summary

Change default HTTP Client to Apache HTTP Client
set automatically snd/rcv socket buffer

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

mzitnik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zhicwu zhicwu linked an issue Sep 5, 2023 that may be closed by this pull request
Preform performance and stability test on different client implementation #1421
Closed
@zhicwu
Copy link
Contributor

zhicwu commented Sep 5, 2023

Thanks @mzitnik. Could share the test results that support this change?

@zhicwu zhicwu self-requested a review September 5, 2023 12:54
@mzitnik mzitnik marked this pull request as draft September 5, 2023 12:58
@mzitnik mzitnik self-assigned this Sep 11, 2023
@mzitnik mzitnik marked this pull request as ready for review September 11, 2023 12:50
@mzitnik mzitnik linked an issue Sep 11, 2023 that may be closed by this pull request
Why does the DEFAULT_BUFFER_SIZE decrease from 8Ki to 4Ki? #1297
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

47.8% 47.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mzitnik mzitnik merged commit b670c4c into main Sep 12, 2023
@mzitnik mzitnik deleted the change_default_http_client branch March 13, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zhicwu zhicwu zhicwu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mzitnik mzitnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preform performance and stability test on different client implementation Why does the DEFAULT_BUFFER_SIZE decrease from 8Ki to 4Ki?

3 participants

@mzitnik @CLAassistant @zhicwu