Fix tryGetTableMetadata to catch all exception types#100990
Open
tuanpach wants to merge 1 commit intoClickHouse:masterfrom
Open
Fix tryGetTableMetadata to catch all exception types#100990tuanpach wants to merge 1 commit intoClickHouse:masterfrom
tryGetTableMetadata to catch all exception types#100990tuanpach wants to merge 1 commit intoClickHouse:masterfrom
Conversation
Previously only `DB::Exception` was caught, allowing `Poco::Exception` and `std::exception` thrown by `Poco::JSON::Parser` or other code inside `getTableMetadataImpl` to propagate unexpectedly from a `try*` API that is supposed to return `false` on failure.
Contributor
|
Workflow [PR], commit [d600685] Summary: ❌
AI ReviewSummaryThis PR updates ClickHouse Rules
Final Verdict
|
clickhouse-gh
bot
added
the
pr-not-for-changelog
Contributor
LLVM Coverage Report
Changed lines: 0.00% (0/14) · Uncovered code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only
DB::Exceptionwas caught, allowingPoco::Exceptionandstd::exceptionthrown byPoco::JSON::Parseror other code insidegetTableMetadataImplto propagate unexpectedly from atry*API that is supposed to returnfalseon failure.Major issue of #92993
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes