-
-
Notifications
You must be signed in to change notification settings - Fork 122
Fix box-shadow at Plugins page #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
There is no bug here. It's like that because it's separating itself off from the bar that contains the checkbox. |
|
I'm not sure what your last comment is designed to show. Even when there's no update listed for the last plugin, there's a clear difference in the border between that plugin and the checkbox. |
|
Yes, we understand each other. And, no it shouldn't be. As I say, it's there to differentiate itself from the area below, which is also done even when there is no update (albeit the differentiation then uses a slightly different method). |
|
Have removed my previous comments, because of info underneath: I understand what you mean now; 2 lines because separate boxes. I think the CP "block-related functions" Changing |
|
The current CSS is targeting the element correctly so far as I can see:
Perhaps there's something else happening on your site, @Guido07111975 ? |
|
It only happens with the "block-related functions" |
|
I'm not sure what you mean. I have Blocks Compatibility switched on. |
|
Only happens if the "block-related functions" is the last one in the list. |
|
I understand everything except what you mean by "block-related functions". As you can see, there's no script tag in the way on my site with Blocks Compatibility on. |
|
You may have turned it on, but do you also have the "block-related functions" notification at your plugins page? Maybe I should close this, as it only happens when having more than one "block-related functions" ánd one of them is the last one in the |
No. Why would I? |
|
Only happens if a plugin has block related functions. Guess you don't have such a plugin installed. And I understand why. |
|
My last try to make myself clear.
But if a plugin for example has an update available, you will see there's no "third" border/box shadow added. |
|
If we replace the script to inside the |
Reverted the CSS as suggested in my reply. Moving the JS to inside the tr does also fix it.
As suggested in my reply. Moving the JS to inside the tr does also fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoiding breaking the list of <tr>s is the way to go!






Description
This minor PR fixes a double box-shadow (border-bottom) when the "block-related functions" notification is displayed as last row at the Plugins page.
For some reason not clear to me the already present styling does not target this notification.
Changing
last-childintolast-of-typefixes this.How has this been tested?
Local install.
Screenshots
Before
After
Types of changes