Security: Add fork PR safety gate to prevent ACE vulnerability#1
Draft
opstk-cicd-auth[bot] wants to merge 1 commit into
Draft
Security: Add fork PR safety gate to prevent ACE vulnerability#1opstk-cicd-auth[bot] wants to merge 1 commit into
opstk-cicd-auth[bot] wants to merge 1 commit into
Conversation
Prevent arbitrary code execution vulnerability in git-auto-commit workflow. Vulnerability: pull_request trigger + uses: ./ + contents: write allows fork PRs to execute arbitrary local action code with write permissions. Fix: Add conditional gate to only run on internal PRs (same repo). Risk gate verdict: workflow-yml-change / medium / comment-only (proper PR review required, no direct push to master) Refs: OPSTK-16743, OPSTK-16732 (Finding 1), OPSTK-16733 (STE source)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: Prevent Fork PR Arbitrary Code Execution
TLDR: Add fork safety gate to prevent CRITICAL ACE vulnerability (OPSTK-16743, OPSTK-16732 Finding 1).
Vulnerability:
pull_requestevents withcontents: writepermission ANDuses: ./(local action execution)Fix:
Add conditional gate to the
git-auto-commitjob:This ensures the job only runs on internal PRs (same repo), not fork PRs.
Risk Assessment:
workflow-yml-changemediumcomment-onlyper Ops Stack security policy (no direct push to master).github/workflows/git-auto-commit.ymlTesting:
References:
Automated fix by Winton (opstk-cicd-auth GitHub App) on behalf of OPSTK-16743.
Human review required before merge.