Move firmware management config to platform types#52
Open
mzella-ll wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves firmware management configuration values from the generic
osal/osal.hheader to the platform-specificosal_platform_types.hheaders.Changes
osal/osal.h.osal/efr32_wisun/osal_platform_types.hosal/freertos/osal_platform_types.hosal/linux/osal_platform_types.h512 * 102430 * 102430 * 1024Motivation
The firmware management slot configuration is platform-dependent. Keeping these values in the generic OSAL header requires platform-specific conditional logic in
osal.h.Moving the configuration to the platform-specific OSAL type headers keeps the generic OSAL interface cleaner and places platform-dependent values closer to the corresponding platform implementation.
Expected behavior
This is a refactoring change. The effective configuration values are preserved, so runtime behavior should remain unchanged.
Related issue
Fixes #51