Skip to content

Commit fe3cc6e

Browse files
thaJeztahthaJeztah
committed
cli/context/store: SA5001: should check returned error before deferring f.Close() (staticcheck)
``` cli/context/store/store_test.go:156:2: SA5001: should check returned error before deferring f.Close() (staticcheck) defer f.Close() ^ cli/context/store/store_test.go:189:2: SA5001: should check returned error before deferring f.Close() (staticcheck) defer f.Close() ^ cli/context/store/store_test.go:240:2: SA5001: should check returned error before deferring f.Close() (staticcheck) defer f.Close() ^ ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 709728e commit fe3cc6e

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎cli/context/store/store_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ func TestImportTarInvalid(t *testing.T) {
153153
tf := path.Join(testDir, "test.context")
154154

155155
f, err := os.Create(tf)
156-
defer f.Close()
157156
assert.NilError(t, err)
157+
defer f.Close()
158158

159159
tw := tar.NewWriter(f)
160160
hdr := &tar.Header{
@@ -186,8 +186,8 @@ func TestImportZip(t *testing.T) {
186186
zf := path.Join(testDir, "test.zip")
187187

188188
f, err := os.Create(zf)
189-
defer f.Close()
190189
assert.NilError(t, err)
190+
defer f.Close()
191191
w := zip.NewWriter(f)
192192

193193
meta, err := json.Marshal(Metadata{
@@ -237,8 +237,8 @@ func TestImportZipInvalid(t *testing.T) {
237237
zf := path.Join(testDir, "test.zip")
238238

239239
f, err := os.Create(zf)
240-
defer f.Close()
241240
assert.NilError(t, err)
241+
defer f.Close()
242242
w := zip.NewWriter(f)
243243

244244
df, err := w.Create("dummy-file")

0 commit comments

Comments
 (0)