Skip to content

fixed missing pragma once in math.cpp#15

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

fixed missing pragma once in math.cpp#15
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 2, 2018

No description provided.

@RobLoach
Copy link
Copy Markdown
Contributor

RobLoach commented Nov 2, 2018

To my knowledge, #pragma once is non-standard. Would it be okay if we switched this for a #ifndef instead?

RobLoach added a commit that referenced this pull request Nov 3, 2018
RobLoach added a commit that referenced this pull request Nov 3, 2018
@RobLoach RobLoach closed this Nov 3, 2018
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 5, 2018

I prefer pragma once because it's meanwhile supported by many compilers. But #ifndef would also be ok for me ;-)

@ghost ghost deleted the patch-1 branch November 5, 2018 06:10
@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 5, 2018

Could you please provide a release with this bug fix? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant