Skip to content

handle \u inside json parser#483

Open
olikraus wants to merge 1 commit intoChaiScript:developfrom
olikraus:json-slash-u
Open

handle \u inside json parser#483
olikraus wants to merge 1 commit intoChaiScript:developfrom
olikraus:json-slash-u

Conversation

@olikraus
Copy link
Copy Markdown

Issue this pull request references: #477

Changes proposed in this pull request

  • Handle the \u escape inside the json string parser

@RobLoach
Copy link
Copy Markdown
Contributor

Is this something that could be pushed forwards to SimpleJSON ?

@olikraus
Copy link
Copy Markdown
Author

Is this something that could be pushed forwards to SimpleJSON ?

Yes the same problem is here also:
https://github.com/nbsdx/SimpleJSON/blob/master/json.hpp#L528

Indeed the conformance report already revealed the problem (section 3, second test):
nbsdx/SimpleJSON#5

So by transfering this pull request to SimpleJSON, the expectation is, that the second test of the string conformance test will succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants