Skip to content

Add pair_conversion registration helper with unit test#482

Merged
RobLoach merged 1 commit intoChaiScript:developfrom
totalgee:pair_conversion
May 24, 2021
Merged

Add pair_conversion registration helper with unit test#482
RobLoach merged 1 commit intoChaiScript:developfrom
totalgee:pair_conversion

Conversation

@totalgee
Copy link
Copy Markdown
Contributor

Issue this pull request references: Discussion in forum thread

Changes proposed in this pull request

  • add a pair_conversion() registration helper, analogous to the existing vector_conversion() and map_conversion() helpers.
  • implement a compiled unit test for the new feature.

@BerndAmend
Copy link
Copy Markdown
Contributor

Why wasn't this merged?

@RobLoach
Copy link
Copy Markdown
Contributor

Whoa, this looks old.

@RobLoach
Copy link
Copy Markdown
Contributor

@BerndAmend Ah, looks like the format change caused a conflict here. Had merged this one by accident first...

@totalgee
Copy link
Copy Markdown
Contributor Author

Thanks!

@BerndAmend
Copy link
Copy Markdown
Contributor

@totalgee will you update or create a new PR?

@totalgee
Copy link
Copy Markdown
Contributor Author

Yes, I will try to make a new PR in the coming days...

@RobLoach
Copy link
Copy Markdown
Contributor

I messed up the pair here. Thank you both for following up and pushing all these forwards! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants