Class with type_conversion from int and "==" operator causes switch s…#422
Open
dinghram wants to merge 2 commits intoChaiScript:developfrom
Open
Class with type_conversion from int and "==" operator causes switch s…#422dinghram wants to merge 2 commits intoChaiScript:developfrom
dinghram wants to merge 2 commits intoChaiScript:developfrom
Conversation
…tatement to compare destroyed objects I added a Function_Push_Pop to save the match_value and the value from evaluating the case statement. This makes the code look like Fold_Right_Binary_Operator_AST_Node::do_oper, which does not have the same defect behavior.
Codecov Report
@@ Coverage Diff @@
## develop #422 +/- ##
===========================================
+ Coverage 71.99% 71.99% +<.01%
===========================================
Files 59 59
Lines 10858 10859 +1
===========================================
+ Hits 7817 7818 +1
Misses 3041 3041
Continue to review full report at Codecov.
|
…tatement to compare destroyed objects Fixes: Class with type_conversion from int and "==" operator causes switch statement to compare destroyed objects ChaiScript#421 Re-uses existing code from Binary_Operator_AST_Node::do_oper to compare equality when processing switch case statements.
Contributor
|
Mind resolving the conflict if this is still relevant? Thanks! |
Contributor
Author
|
Hi, Rob. The current Develop branch cannot seem to compile with Visual
Studio 2017 15.8.8 with /std:c++17 and /permissive- due to the usage of
constexpr that doesn't seem to work:
proxy_functions.hpp line 80:
constexpr auto dynamic_object_type_info = user_type<Dynamic_Object>();
If I can't compile, I can't verify that we still need the bug fix and can't
verify that the merged code works properly.
Thanks,
Don Inghram
…On Thu, Nov 1, 2018 at 3:51 PM Rob Loach ***@***.***> wrote:
Mind resolving the conflict if this is still relevant? Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#422 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWCfOXW-DyZf1YFXmyFlEwyFOlOgp_Ggks5uq2zxgaJpZM4ScvdR>
.
|
Member
|
Even with the constexpr changes in place there still one more compiler bug in MSVC, I just sent in a bug report for it, hopefully at some point in the near future we can get it working again. |
Contributor
Author
|
Great, looking forward to it.
Don
…On Fri, Dec 28, 2018, 11:48 AM Jason Turner ***@***.***> wrote:
Even with the constexpr changes in place there still one more compiler bug
in MSVC, I just sent in a bug report for it, hopefully at some point in the
near future we can get it working again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#422 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWCfOUE3cOo6ElnyId85Ng7T8WqGNFWAks5u9meTgaJpZM4ScvdR>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tatement to compare destroyed objects
I added a Function_Push_Pop to save the match_value and the value from evaluating the case statement. This makes the code look like Fold_Right_Binary_Operator_AST_Node::do_oper, which does not have the same defect behavior.
Issue this pull request references: #421
Changes proposed in this pull request