[Rebase] [ENG-9177] Removed ember#11531
Open
antkryt wants to merge 6 commits intoCenterForOpenScience:feature/pbs-26-2from
Open
[Rebase] [ENG-9177] Removed ember#11531antkryt wants to merge 6 commits intoCenterForOpenScience:feature/pbs-26-2from
antkryt wants to merge 6 commits intoCenterForOpenScience:feature/pbs-26-2from
Conversation
Vlad0n20
approved these changes
Jan 9, 2026
Contributor
Vlad0n20
left a comment
Vlad0n20
left a comment
There was a problem hiding this comment.
LGTM!
There is one point with tests
|
|
||
| def test_get_user_by_external_info(self): | ||
| service_url = 'http://localhost:5000/dashboard/' | ||
| service_url = 'http://localhost:5000/my_projects/' |
Contributor
There was a problem hiding this comment.
Test assertions use /my_projects/ but actual route is /myprojects/
Collaborator
|
@antkryt There are some merge conflicts that needs taken care of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Original PR was rebased and contains unrelated commits.
This PR reconstructs the intended changes by cherry-picking the last 6 commits only.
Changes
QA Notes
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-9177