[ENG-8742] include ignored components when create a view-only link#11269
Merged
Johnetordoff merged 3 commits intoCenterForOpenScience:feature/pbs-25-16from Sep 2, 2025
Merged
Conversation
ihorsokhanexoft
changed the title
Johnetordoff
requested changes
Aug 28, 2025
Contributor
|
@ihorsokhanexoft I was very surprised with your report of the tests passing locally, yet failing in the CI, but I was able to reproduce the phenomenon and confirmed you were correct. There is some issue with our code working with GHA, that seems like a separate issue. @adlius That might need it's our ticket, I can't see what in this PR could cause that local tests to pass. Maybe an issue with the base branch? |
Johnetordoff
approved these changes
Sep 2, 2025
Contributor
Johnetordoff
left a comment
Johnetordoff
left a comment
There was a problem hiding this comment.
@adlius This is the right idea, but in the future we'd split this code into two seperate files to represent business logic better, but close enough for now.
Johnetordoff
merged commit d6b7edb
into
CenterForOpenScience:feature/pbs-25-16
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Components are ignored when user creates a view-only link and includes components
Ticket
https://openscience.atlassian.net/browse/ENG-8742?atlOrigin=eyJpIjoiYjg1ZGE2MzI3YjMyNGE2YWFiMDYyOGMyMjQyOTJhYmYiLCJwIjoiaiJ9