Feat - development server reverse proxy#168
Closed
chiku-samugari wants to merge 3 commits intoCenterForOpenScience:mainfrom
Closed
Feat - development server reverse proxy#168chiku-samugari wants to merge 3 commits intoCenterForOpenScience:mainfrom
chiku-samugari wants to merge 3 commits intoCenterForOpenScience:mainfrom
Conversation
Author
|
I found that the Cookie Authentication feature proposed in this draft PR has been implemented, in a better approach than mine. I close this PR for that reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Companion to osf.io PR #11224.
Enables osf.io (localhost:5000) to act as a reverse proxy for the angular-osf dev server (localhost:4300) during local development.
Key points
1 .
baseHrefResource URLs need to start with
/angular_osfto be properly proxied.baseHrefis set to/angular_osf/assets/, ensuring that URLs such as/@vite/clientresolve correctly.2 . Cookie authentication
Although a dedicated login UI is not included, the app now reads the standard auth cookies. If the user is already authenticated, their username appears in the top-right corner. One possible verification flow is as follows:
PRIMARY_WEB_APP="ember_osf_web"(osf.io/website/settings/local.py).http://localhost:5000and sign in viaember-osf-web.PRIMARY_WEB_APPto"angular_osf"and restart thewebservice.http://localhost:5000;angular-osfloads and displays the logged-in user.